make : support overriding CFLAGS/CXXFLAGS/CPPFLAGS/LDFLAGS #2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Aug 30, 2023
cebtenzzre
commented
Aug 30, 2023
cebtenzzre
force-pushed
the
overridable-cflags
branch
from
f2e297c to
ed3fe45
Compare
|
Is this good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements something I've been wanting for a long time - the ability to override build flags via the command line when running
make.For example, one can now easily check for missing
__attribute__((format(printf, ...)))attributes:Or make a release build with assertions enabled:
All without having to edit the Makefile.