make : use new flag variables for recent changes #3019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhen0409
reviewed
Sep 5, 2023
Comment on lines
-371
to
+360
| MK_CPPFLAGS += -DGGML_USE_METAL #-DGGML_METAL_NDEBUG | ||
| MK_CPPFLAGS += -DGGML_USE_METAL |
There was a problem hiding this comment.
It's come from 3a00764.
@ggerganov Can we have a flag like LLAMA_METAL_NDEBUG for that? I use this flag when using tool like llama-bench, other times I think it would be useful not to enable the flag.
There was a problem hiding this comment.
Yes, we can add LLAMA_METAL_NDEBUG to optionally disable metal debug prints.
I still prefer to have them enabled by default, but in the future, when things are more stable, we will disable them by default.
ggerganov
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PRs were recently merged that touch CFLAGS/CXXFLAGS/LDFLAGS, but were based on a version of llama.cpp prior to #2886 being merged. The Makefile has been updated to use MK_CFLAGS etc. where appropriate.