Clarify how to be added to allow list #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 28.0.4 to 28.0.5. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md) - [Commits](kulshekhar/ts-jest@v28.0.4...v28.0.5) --- updated-dependencies: - dependency-name: ts-jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…pescript-eslint/eslint-plugin-5.28.0 build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.27.1 to 5.28.0
…pes/jest-28.1.2 build(deps-dev): bump @types/jest from 28.1.1 to 28.1.2
…pescript-4.7.4 build(deps-dev): bump typescript from 4.7.3 to 4.7.4
…-jest-28.0.5 build(deps-dev): bump ts-jest from 28.0.4 to 28.0.5
Bumps [eslint](https://github.com/eslint/eslint) from 8.17.0 to 8.18.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.17.0...v8.18.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…lint-8.18.0 build(deps-dev): bump eslint from 8.17.0 to 8.18.0
…lint-plugin-jsdoc-39.3.3 build(deps-dev): bump eslint-plugin-jsdoc from 39.3.2 to 39.3.3
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.27.1 to 5.29.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.29.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…pescript-eslint/parser-5.29.0 build(deps-dev): bump @typescript-eslint/parser from 5.27.1 to 5.29.0
Added to mailrepo:
- url - link to access files. Should be buildable at runtime
but that is asking for more than I can currently offer
- descriptiveName - term to be used for messages
Signed-off-by: Chris. Webster <[email protected]>
Make email repo more generic via config
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 28.1.2 to 28.1.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [test-smtp-server](https://github.com/webstech/test-smtp-server) from 0.9.3 to 0.9.4. - [Release notes](https://github.com/webstech/test-smtp-server/releases) - [Commits](https://github.com/webstech/test-smtp-server/commits) --- updated-dependencies: - dependency-name: test-smtp-server dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.28.0 to 5.29.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.29.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…pes/jest-28.1.3 build(deps-dev): bump @types/jest from 28.1.2 to 28.1.3
…st-smtp-server-0.9.4 build(deps-dev): bump test-smtp-server from 0.9.3 to 0.9.4
…pescript-eslint/eslint-plugin-5.29.0 build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.28.0 to 5.29.0
Bumps [jest-junit](https://github.com/jest-community/jest-junit) from 13.2.0 to 14.0.0. - [Release notes](https://github.com/jest-community/jest-junit/releases) - [Commits](jest-community/jest-junit@v13.2.0...v14.0.0) --- updated-dependencies: - dependency-name: jest-junit dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…st-junit-14.0.0 build(deps-dev): bump jest-junit from 13.2.0 to 14.0.0
Signed-off-by: Chris. Webster <[email protected]>
Signed-off-by: Chris. Webster <[email protected]>
Signed-off-by: Chris. Webster <[email protected]>
Prep for possible new range-diff feature support
This change intorduces support for a new pull request description footer: Range-Diff: false This will bypass generation of the range-diff between patch versions. The range-diff output will be replaced with instructions for generating it locally. The users of this feature should comment if the range-diff is not relevant. Signed-off-by: Chris. Webster <[email protected]>
Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) and [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest). These dependencies needed to be updated together. Updates `jest` from 28.1.1 to 28.1.2 - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/commits/v28.1.2/packages/jest) Updates `@types/jest` from 28.1.3 to 28.1.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint](https://github.com/eslint/eslint) from 8.18.0 to 8.19.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.18.0...v8.19.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 10.8.1 to 10.8.2. - [Release notes](https://github.com/TypeStrong/ts-node/releases) - [Commits](TypeStrong/ts-node@v10.8.1...v10.8.2) --- updated-dependencies: - dependency-name: ts-node dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.7.5 to 6.7.6. - [Release notes](https://github.com/nodemailer/nodemailer/releases) - [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md) - [Commits](nodemailer/nodemailer@v6.7.5...v6.7.6) --- updated-dependencies: - dependency-name: nodemailer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…st-and-types/jest-28.1.2 build(deps-dev): bump jest and @types/jest
…lint-plugin-jsdoc-39.4.0 build(deps-dev): bump eslint-plugin-jsdoc from 39.3.24 to 39.4.0
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.40.1 to 5.42.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.42.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…pescript-eslint/eslint-plugin-5.42.0 build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.40.1 to 5.42.0
This really does not do justice to the project yet, but it is *something*. Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
By mistake, this page was updated as Markdown, but it is a static web page, so it really needs to be HTML... Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Better explanation, some CSS experiments, fun all around. Signed-off-by: Johannes Schindelin <[email protected]>
Since the SubmittingPatches page is nicely formatted on the Git website, it makes for a nicer reading experience, so let's link to that instead of the raw file on GitHub.
Signed-off-by: Matthias Aßhauer <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Mark HTML files as such with the 'diff' attribute, so that the appropriate '<h[1-9]>' title is shown in the hunk header in diffs.
In a subsequent commit we want to mention that it is prefered to use an empty desccription for a single commit PR, since the description is copied as an in-patch commentary and having the same text twice (once in the commit messge and once in the in-patch commentary) decreases the signal-to-noise ratio for reviewers. Before doing so, let's convert part of the first paragraph of the "How can you use GitGitGadget?" section into an unorderded list. This will make the text clearer when we mention single commit PRs later.
We refer readers to the MyFirstContribution tutorial when mentioning the cover letter. Let's do even better and link directly to the section of the tutorial that explains the purpose and content of the cover letter.
For single commit PRs, GitHub prepends the commit message to the PR description, before the PR template. Contributors will then (hopefully) remove the template and keep the rest of the description. Since the PR description is added as an in-patch commentary for single-commit PRs, the same text appears twice in the generatred email (once in the commit messge and once in the in-patch commentary), decreasing the signal-to-noise ratio for reviewers. Let's instruct readers to empty the PR description for single commit PRs. This partly addresses: gitgitgadget/gitgitgadget#340
On first reading, I found very confusing to understand how I could be added to allow list. I just tried creating the PR anyway and discovered that the first message by your bot explains how to add someone. I believe that it would improve first user interaction if they already knew how to find this user that may allow them. (Even better would be to have it automated, but that's a more complex task I don't dare to try to work on)
Arthur-Milchior
force-pushed
the
clarify2
branch
from
d033933 to
f5ea3b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first reading, I found very confusing to understand how I could be added to allow list. I just tried creating the PR anyway and discovered that the first message by your bot explains how to add someone. I believe that it would improve first user interaction if they already knew how to find this user that may allow them. (Even better would be to have it automated, but that's a more complex task I don't dare to try to work on)
This is the clone of PR #13 that gots closed for some reason I don't really get. But it seems like my rebase had a problem, which, as far as I understand, can only be caused if a force-push removed a commit my original PR was based upon