Skip to content

Clarify how to be added to allow list #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

Arthur-Milchior
Copy link
Contributor

On first reading, I found very confusing to understand how I could be added to allow list. I just tried creating the PR anyway and discovered that the first message by your bot explains how to add someone. I believe that it would improve first user interaction if they already knew how to find this user that may allow them. (Even better would be to have it automated, but that's a more complex task I don't dare to try to work on)

Clone of #14, applying required correction. And this time I figured out what I got wrong which caused it to be closed. Very sorry for the noise

On first reading, I found very confusing to understand how I could be added to
allow list. I just tried creating the PR anyway and discovered that the first
message by your bot explains how to add someone. I believe that it would improve
first user interaction if they already knew how to find this user that may allow
them. (Even better would be to have it automated, but that's a more complex task
I don't dare to try to work on)
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dscho dscho merged commit 45755e2 into gitgitgadget:main Nov 4, 2022
@dscho
Copy link
Member

dscho commented Nov 4, 2022

(Even better would be to have it automated, but that's a more complex task I don't dare to try to work on)

The reason it is not automated is that it is a crude (but so far effective) anti-spam measure.

GitGitGadget could be modified to allow everybody to /submit, but given the rate of low-quality/spam PRs we see in git/git and in gitgitgadget/git, that would only contribute to marking the GitGitGadget email as spammy on the Git mailing list, which is something we naturally want to avoid.

@Arthur-Milchior Arthur-Milchior deleted the clarify_again branch November 4, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants