Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Sep 10, 2025

We accidentally kept dbAnalysisConfig here when refactoring this into its own function, instead of analysis. This meant that the check never succeeded, unless code-quality was the only active analysis.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from a team as a code owner September 10, 2025 15:15
@Copilot Copilot AI review requested due to automatic review settings September 10, 2025 15:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the runInterpretResultsFor function where the wrong analysis configuration was being used to determine if Code Quality category fix should be applied. The fix ensures that the category correction logic properly checks the individual analysis type rather than the database analysis configuration.

  • Corrects variable reference from dbAnalysisConfig to analysis in category check
  • Ensures Code Quality category fix is applied when processing individual Code Quality analyses

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/analyze.ts Fixed incorrect variable reference in Code Quality category check
lib/analyze-action.js Generated JavaScript file (no review needed per guidelines)

@mbg mbg requested a review from henrymercer September 10, 2025 15:16
@mbg mbg enabled auto-merge September 10, 2025 15:26
@mbg mbg merged commit b660efd into main Sep 10, 2025
290 checks passed
@mbg mbg deleted the mbg/fix/category-check branch September 10, 2025 15:30
@github-actions github-actions bot mentioned this pull request Sep 10, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants