Merge main into releases/v3 #3104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
Mergeback v3.30.2 refs/heads/releases/v3 into main
Co-authored-by: henrymercer <[email protected]>
…336-b8b24b72dba3 Remove --intra-layer-parallelism flag from CodeQL CLI commands
This introduces a new internal environment variable flag (`CODEQL_ACTION_SARIF_DUMP_DIR`) that, when set to `true`, causes the SARIF file that will be uploaded to be dumped to the specified directory. The filename will be `upload.sarif` or `upload.quality.sarif` depending on the upload target.
Dump soon to be uploaded SARIF on request
…plate Add a reminder to the PR template that this is a public repo
…ize-limit Overlay: Increase size limit for cached overlay base database
Fix `runInterpretResultsFor` using the wrong `AnalysisConfig` for Code Quality `category` fix
There was a problem hiding this comment.
Pull Request Overview
This is a release-PR merging several pull requests into the releases/v3 branch for version 3.30.3. The main purpose is to consolidate changes from multiple PRs including bug fixes, feature updates, and improvements to overlay database functionality.
- Version bump to 3.30.3 with corresponding CHANGELOG entry
- Addition of SARIF dump functionality for debugging purposes
- Updates to overlay database size limits and documentation
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump from 3.30.2 to 3.30.3 |
| CHANGELOG.md | Added entry for version 3.30.3 indicating no user facing changes |
| src/upload-lib.ts | Added SARIF dump functionality with new dumpSarifFile function |
| src/environment.ts | Added SARIF_DUMP_DIR environment variable definition |
| src/overlay-database-utils.ts | Updated overlay database size limit and improved documentation |
| src/codeql.ts | Removed --intra-layer-parallelism flag from database run-queries command |
| src/codeql.test.ts | Updated test expectation to reflect removal of --intra-layer-parallelism flag |
| src/analyze.ts | Fixed variable reference from dbAnalysisConfig to analysis |
| .github/pull_request_template.md | Added comment about public repository visibility |
Files not reviewed (1)
- package-lock.json: Language not supported
| // accepted by the Code Quality backend. | ||
| let category = automationDetailsId; | ||
| if (dbAnalysisConfig.kind === analyses.AnalysisKind.CodeQuality) { | ||
| if (analysis.kind === analyses.AnalysisKind.CodeQuality) { |
There was a problem hiding this comment.
The variable analysis is used here but it's not clear from the context that this variable exists in the current scope. The previous code was using dbAnalysisConfig.kind which suggests this might be a variable naming issue or missing variable definition.
Copilot uses AI. Check for mistakes.
cklin
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging b660efd into
releases/v3.Conductor for this PR is @cklin.
Contains the following pull requests:
runInterpretResultsForusing the wrongAnalysisConfigfor Code Qualitycategoryfix #3103 (@mbg)Please do the following:
releases/v3branch.Create a merge commitis selected rather thanSquash and mergeorRebase and merge.