C#: Include "phi reads" in DataFlow::Node
#10927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowImplCommon.qll
Fixed
Show fixed
Hide fixed
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
from
f48f2ea to
20fab36
Compare
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
3 times, most recently
from
8395647 to
35843f8
Compare
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
2 times, most recently
from
3c57529 to
fa8e721
Compare
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
2 times, most recently
from
8ccdb9c to
17de1f1
Compare
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
3 times, most recently
from
0f7e1c8 to
b2215cc
Compare
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
2 times, most recently
from
7358f28 to
b57847f
Compare
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
from
b57847f to
dbeba05
Compare
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
from
dbeba05 to
ac29f02
Compare
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
from
ac29f02 to
1a8cd6e
Compare
hvitved
force-pushed
the
csharp/phi-reads-in-data-flow-graph
branch
from
1a8cd6e to
7cab6b5
Compare
michaelnebel
approved these changes
Nov 23, 2022
| } | ||
| } | ||
|
|
||
| import Cached | ||
|
|
||
| private module Deprecated { |
There was a problem hiding this comment.
Is this to avoid deprecation warnings or something like that?
There was a problem hiding this comment.
It was simply to group the deprecated predicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add SSA phi-read nodes to the
DataFlow::Nodetype, both for C# and CIL.The benefit of doing this (copied from the other PR) is to be able to avoid the same potential combinatorial explosion that we also avoid by including normal phi nodes in the data flow graph:
graph TD; A-->read_phi; B-->read_phi; C-->read_phi; read_phi-->D; read_phi-->E; read_phi-->F;Assuming that
A,...,Fread the same underlying variable asread_phi, one can reduce the number of data flow edges from 9 (quadratic) to 6 (linear) by including theread_phijoin-point.The work of this PR basically amounts to shifting from
Ssa::DefinitiontoSsaImpl::DefinitionExt.On a local database, making this change I was able to reduce the size of
localFlowStepfrom 89,121,074 to 8,349,054 tuples.