Ruby: Include SSA "phi reads" in DataFlow::Node #11517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| SsaInput::variableRead(bb2, i2, _, false) | ||
| } | ||
|
|
||
| /** Same as `lastRefRedef`, but skips uncertain reads. */ | ||
| pragma[nomagic] | ||
| private predicate lastRefSkipUncertainReads(Definition def, SsaInput::BasicBlock bb, int i) { | ||
| private predicate lastRefSkipUncertainReadsExt(DefinitionExt def, SsaInput::BasicBlock bb, int i) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter
aibaars
force-pushed
the
phi-reads-in-data-flow-graph
branch
4 times, most recently
from
ea99167 to
85a726b
Compare
hvitved
requested changes
Dec 5, 2022
aibaars
force-pushed
the
phi-reads-in-data-flow-graph
branch
from
7c21758 to
7f2ba7d
Compare
aibaars
force-pushed
the
phi-reads-in-data-flow-graph
branch
from
7f2ba7d to
d862972
Compare
hvitved
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add #11198 nodes to the DataFlow::Node type. See also: #10927 (comment)