Skip to content

Kots admin UI bug - in-cluster S3 fields don't go away #10257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucasvaltl opened this issue May 25, 2022 · 1 comment · Fixed by #12218
Closed

Kots admin UI bug - in-cluster S3 fields don't go away #10257

lucasvaltl opened this issue May 25, 2022 · 1 comment · Fixed by #12218
Assignees
@Pothulapati
Labels
type: bug Something isn't working

Comments

@lucasvaltl
Copy link
Contributor

lucasvaltl commented May 25, 2022 •
edited
Loading

Bug description

In the KOTS installation Configuration section, under Container registry, you can get into a state where fields are being shown that should be hidden.

Steps to reproduce

Check the in-cluster option, then select the S3 alternative. Uncheck the in-cluster option - the S3 specific fields stay there instead of going away.

https://www.loom.com/share/1cbe5fb5122b499797b41aeefbba8290

Workspace affected

No response

Expected behavior

The S3 specific fields should go away when unselecting In-cluster container registry.

Example repository

No response

Anything else?

No response
@lucasvaltl lucasvaltl added the type: bug Something isn't working label May 25, 2022
@lucasvaltl lucasvaltl mentioned this issue May 25, 2022
Closed
27 tasks
@lucasvaltl lucasvaltl moved this from 🧊Backlog to 📓Scheduled in 🚚 Security, Infrastructure, and Delivery Team (SID) Jul 6, 2022
Pothulapati added a commit that referenced this issue Aug 19, 2022
@Pothulapati
[kots] show s3 options only when incluster is enabled
516c7e9 
Fixes #10257

This PR updates the `reg_incluster_storage_s3*` options to
only be enabled both when `incluster` is enabled, and `s3` is
selected, instead of only the latter being used currently.

Signed-off-by: Tarun Pothulapati <[email protected]>
@Pothulapati Pothulapati mentioned this issue Aug 19, 2022
Merged
1 task
@Pothulapati
Copy link
Contributor

Pothulapati commented Aug 19, 2022 •
edited
Loading

Verified that this still happens, and raised #12218 to fix that

@Pothulapati Pothulapati moved this from 📓Scheduled to ⚒In Progress in 🚚 Security, Infrastructure, and Delivery Team (SID) Aug 19, 2022
@Pothulapati Pothulapati self-assigned this Aug 19, 2022
Repository owner moved this from ⚒In Progress to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Aug 19, 2022
roboquat pushed a commit that referenced this issue Aug 19, 2022
@Pothulapati @roboquat
[kots] show s3 options only when incluster is enabled
fa5d957 
Fixes #10257

This PR updates the `reg_incluster_storage_s3*` options to
only be enabled both when `incluster` is enabled, and `s3` is
selected, instead of only the latter being used currently.

Signed-off-by: Tarun Pothulapati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pothulapati Pothulapati

Labels
type: bug Something isn't working
Projects
No open projects
🚚 Security, Infrastructure, and Delivery Team (SID)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[kots] show registry_s3 options only when incluster is enabled gitpod-io/gitpod
2 participants
@Pothulapati @lucasvaltl