[kots] show registry_s3 options only when incluster is enabled
#12218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10257 This PR updates the `reg_incluster_storage_s3*` options to only be enabled both when `incluster` is enabled, and `s3` is selected, instead of only the latter being used currently. Signed-off-by: Tarun Pothulapati <[email protected]>
github-actions
bot
added
the
team: delivery
mrsimonemms
approved these changes
Aug 19, 2022
|
Good catch on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
reg_incluster_storage_s3*options toonly be enabled both when
inclusteris enabled, ands3isselected, instead of only the latter being used currently.
https://www.loom.com/share/2278f177783d4b9986fe3a2f2b316537
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #10257
How to test
Follow steps in https://www.loom.com/share/1cbe5fb5122b499797b41aeefbba8290, and
see that it does not happen
Release Notes
Documentation
Werft options: