multi-repo: opening workspace file loses task's terminal window (desktop VSCode)

[david-bakin]

Bug description

Using desktop VSCode I have a multi repo. When it opens in VSCode desktop it only displays the main repo (in the explorer bar). But I have a VSCode workspace file in the repo which VSCode finds and it offers to open that. I click "Yes" and the VSCode window refreshes and now the explorer bar shows all the repos in my workspace, as it should. But the task terminal window disappears - I have to open a new one.

In the past with this same setup when I opened the workspace file the task terminal window came back with the output from the task present.

This gitpod.yml has one task only, it's terminal window is what I'm talking about.

Unfortunately, I can't pinpoint when this change in behavior happened. It definitely was the case that it worked before I switched to the ssh remote (v.s. the gitpod remote desktop thing). But I also think it worked for awhile after I switched to the ssh remote

Steps to reproduce

With VSCode desktop, open a multi repo workspace, e.g., https://gitpod.io/start/#bakinsbits-gitpodsetupf-x243p43jh48, based on https://gitlab.com/bakins-bits/gitpod-setup-for-bitcoin-core-dev

VSCode desktop opens, and after I agree that I trust this folder and its parents, the (single) init+command task terminal window is visible, and it asks to open the workspace file bitcoin.code-workspace which is at the root of the main repo:

I click "yes" and the window refreshes and I see no terminal window:

So I execute the menu View > Terminal and I see a brand new terminal window, and VSCode knows of no others:

Workspace affected

bakinsbits-gitpodsetupf-x243p43jh48 (and others)

Expected behavior

After opening the workspace file I should continue to see an active terminal window that is the task that .gitpod.yml ran (init and command phases).

Example repository

Snapshot url: https://gitpod.io/#snapshot/479b394b-ee03-4b7d-a065-bf15f52b7a77

Taken right after opening the workspace before it offered to open the VSCode workspace file. If on restore it doesn't itself offer to open the VSCode workspace file you can do it yourself: Just navigate to and then click /workspace/gitpod-setup-for-bitcoin-core-dev/bitcoin.code-workspace and then it offers you a "Open Workspace" button in the lower-right to click on.

Anything else?

Could be a gitpod change, could be a VSCode change, not sure.

gp version reports se-db-perf.0

Gitpod extension (installed in desktop): v0.0.401 Gitpod Remote extension (installed in desktop): v0.0.32`

VSCode about box says:

Version: 1.68.1
Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630
Date: 2022-06-14T12:48:58.283Z (2 wks ago)
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Windows_NT x64 10.0.22000

[akosyakov]

Uh, thank you for reporting it! It is a known issue that terminals are get lost in VS Code Desktop 1.68 because of a regression [1]. It was fixed for 1.69 which should be released end of this week. We are also working in more sustainable way to handle terminal closing [2].

That's said I think we should improve opening in multi repo setup that you don't need to click Open Workspace each time. @jeanp413 could you have a look please? 🙏

[jeanp413]

I tried reproducing the issue with *.code-workspace file not opening by default with your repo and others but failed 😞
I see that it's properly configured in your .gitpod.yml file in workspaceLocation too so I run out of ideas.
@david-bakin could you collect logs and share them with us and your settings.json too

[david-bakin]

@david-bakin could you collect logs and share them with us and your settings.json too

Sent to support@gitpod.io.