Fix workspace location when opening in vscode desktop

[jeanp413]

Related Issue(s)

Fixes #11101

How to test

1. Select vscode desktop in dashboard
2. Open https://gitlab.com/bakins-bits/gitpod-setup-for-bitcoin-core-dev in prev env
3. When vscode desktop connects to workspace check the workspace openup with three folders by default - bitcoin btcdeb gitpod-setup-for-bitcoin-core-dev

Release Notes

NONE

Werft options:

• /werft with-preview

[jeanp413]

/werft run

👍 started the job as gitpod-build-jp-fix-ws-location.1
(with .werft/ from main)

[jeanp413]

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-jp-fix-ws-location.3
(with .werft/ from main)

[akosyakov]

@jeanp413 It does not seem to work for me. It always opens / for me.

I tried both latest and stable.

[mustard-mh]

I can't see any differences between prev env and prod env (I use Open in VS Code command in browser code)

BTW. I found a bug (prod env) that after a close Desktop VSCode, browser code's terminals will be terminated...Maybe I should file an issue?

[akosyakov]

BTW. I found a bug (prod env) that after a close Desktop VSCode, browser code's terminals will be terminated...Maybe I should file an issue?

It is known and fixed, but needs a new release of VS Code Desktop, please see #11101 (comment)

[jeanp413]

I can't see any differences between prev env and prod env (I use Open in VS Code command in browser code)

@mustard-mh You need to select vscode desktop in dashboard, using vscode web uses a different logic in gitpod-web

[mustard-mh]

rebased to origin/main to fix build error

[mustard-mh]

@mustard-mh You need to select vscode desktop in dashboard, using vscode web uses a different logic in gitpod-web

Not works too

Not works since I expected what How to Test section said

file bitcoin.code-workspace is open by default

I will update PR description

[mustard-mh]

And why this PR can fix issue #11101 ?

[mustard-mh]

We should remove contentReady in JetBrains too

gitpod/components/ide/jetbrains/image/status/main.go

Lines 70 to 77 in 2c5cd4c

	// wait until content ready
	contentStatus, wsInfo, err := resolveWorkspaceInfo(context.Background())
	if err != nil || wsInfo == nil || contentStatus == nil || !contentStatus.Available {
	log.WithError(err).WithField("wsInfo", wsInfo).WithField("cstate", contentStatus).Error("resolve workspace info failed")
	return
	}
	log.WithField("cost", time.Now().Local().Sub(startTime).Milliseconds()).Info("content available")

[mustard-mh]

And why this PR can fix issue #11101 ?

Terminal issue will be fixed by Microsoft right? and this PR to fix the first open file related in #11101 ?

[mustard-mh]

Our docs about workspaceLocation are wrong .gitpod.yml ref and workspace location doc we should change them. It means the pointer of .code-workspace file as our schema said.

Doc makes me confused 🥲

@loujaybee @jeanp413

[mustard-mh]

Nice job JP 🎉 Need to change #11131 (comment)

I tested this PR in prev env with vscode desktop selected, it works as expected - open up with three folders.

Prod	Prev Env

[mustard-mh]

Also tested with JetBrains and it didn't break

[mustard-mh]

👍