-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix workspace location when opening in vscode desktop #11131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/werft run 👍 started the job as gitpod-build-jp-fix-ws-location.1 |
2875a93
to
0454f4d
Compare
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-jp-fix-ws-location.3 |
0454f4d
to
5bd68f7
Compare
@jeanp413 It does not seem to work for me. It always opens I tried both latest and stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any differences between prev env
and prod env
(I use Open in VS Code
command in browser code)
BTW. I found a bug (prod env
) that after a close Desktop VSCode, browser code's terminals will be terminated...Maybe I should file an issue?
It is known and fixed, but needs a new release of VS Code Desktop, please see #11101 (comment) |
@mustard-mh You need to select vscode desktop in dashboard, using vscode web uses a different logic in gitpod-web |
198325c
to
2c5cd4c
Compare
rebased to |
Not works since I expected what
I will update PR description |
And why this PR can fix issue #11101 ? |
We should remove gitpod/components/ide/jetbrains/image/status/main.go Lines 70 to 77 in 2c5cd4c
|
Our docs about Doc makes me confused 🥲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job JP 🎉 Need to change #11131 (comment)
I tested this PR in prev env with vscode desktop
selected, it works as expected - open up with three folders.
Prod | Prev Env |
---|---|
![]() |
![]() |
2c5cd4c
to
8f432a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Related Issue(s)
Fixes #11101
How to test
bitcoin
btcdeb
gitpod-setup-for-bitcoin-core-dev
Release Notes
Werft options: