-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Rollout BlockedRepositories UI #11462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@geropl For this iteration, we could reuse the text-based pattern we already have in project-level environment variables, see example settings. I'll open a follow-up issue with some more minor UX issues. |
/werft run with-preview=true 👍 started the job as gitpod-build-gpl-11030-brs.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the installer
side, but How about also removing the BlockedRepository
type both from
install/installer/pkg/config/v1/experimental/experimental.go
install/pkg/components/server/types.go
as its not used anymore.
/hold for the same
Thank you @Pothulapati , done! 🙏 /unhold |
Description
This PR does:
delete
functionality to work cross-clusterRelated Issue(s)
Prior PR: #11446
Fixes: #11030
How to test
Release Notes
Documentation
Werft options: