Skip to content

Remove redirection to team context when previous context was a team #7716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Jan 20, 2022 · 7 comments
Closed

Remove redirection to team context when previous context was a team #7716

gtsiolis opened this issue Jan 20, 2022 · 7 comments
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code user experience

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 20, 2022

Problem to solve

Back in #5854 and #5894, we redirected users to the last selected team when loading gitpod.io. Cc @AlexTugarev @jankeromnes

Also, we recently merged all workspaces lists into a single list in #7606. Cc @svenefftinge

This makes redirecting to the last selected team, less useful or practical, especially with the upcoming changes to allow users to start workspaces for any project or team from the workspaces and other pages, see #7564. 💡

See relevant discussion from discord. Cc @jacobparis

Proposal

Redirect to the new single workspaces list when loading gitpod.io.

@gtsiolis gtsiolis added user experience component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Jan 20, 2022
@jacobparis
Copy link

Redirect to the new single workspaces list when loading gitpod.io.

This would effectively solve the problem for me and remove the need for any dedicated "workspaces" nav items. As long as there is a gitpod logo within arms reach I can click that and get where I want to be

@svenefftinge
Copy link
Member

svenefftinge commented Jan 20, 2022

Proposal

Redirect to the new single workspaces list when loading gitpod.io.

I think this is already the case.

FWIW, I like @jacobparis proposal to add a workspaces button to the global nav on the right.
What do you think, @gtsiolis?

@jldec jldec changed the title Redirect to the new single workspaces list when loading gitpod.io Proposal: Redirect to the workspaces list when loading gitpod.io and previous context was a team. Jan 20, 2022
@gtsiolis
Copy link
Contributor Author

I think this is already the case.

@svenefftinge There's a small edge case where if the exit page is a team or a project page, openining gitpod.io will redirect back to the team page (projects list) instead of the new single workspaces list.

Besides this, adding a global workspaces menu sounds great! 💯

🍊 🍊 🍊 🍊

Things to consider while making this change:

  1. If Workspaces link is added on the right, consider hiding help links (Docs, Help) in their own dropdown menu or insie the user menu so that link weight remains balanced.
  2. Consider moving the Workspaces towards the left side of the navigation if possible as usually more important elements are placed on this side. See F-Pattern[1][2][3][...]

@jldec jldec changed the title Proposal: Redirect to the workspaces list when loading gitpod.io and previous context was a team. Remove redirection to team context (when loading gitpod.io and previous context was a team) Feb 3, 2022
@jldec jldec changed the title Remove redirection to team context (when loading gitpod.io and previous context was a team) Remove redirection to team context when previous context was a team Feb 21, 2022
@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 25, 2022
@gtsiolis
Copy link
Contributor Author

The existing behavior will become irrelevant and actually helpful once we make the changes in #8385. Cc @jldec

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label May 26, 2022
@jacobparis
Copy link

I can confirm the changes in #8385 solve the original concerns I had on Discord back in january

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jun 7, 2022

Closing this as the issues described here are mostly no longer relevant after the updates in #8385 which have been already deployed on production. One small further improvement has been described in follow up issue in #10496.

@gtsiolis gtsiolis closed this as completed Jun 7, 2022
@gtsiolis gtsiolis moved this to Done in 🍎 WebApp Team Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code user experience
Projects
Status: No status
Development

No branches or pull requests

3 participants