Skip to content

[dashboard] single workspaces list #7606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

[dashboard] single workspaces list #7606

merged 1 commit into from
Jan 14, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jan 14, 2022 •
edited
Loading

reverts the multiple workspaces lists under teams and projects
reintroduces a single workspaces list that shows all my workspaces

fixes #7604

Release Notes

Removed "workspaces" from projects and teams and have a single global workspaces list, that shows all my workspaces.
Made the single "workspaces" list the default landing place in the dashboard.

@codecov
Copy link

codecov bot commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #7606 (1d1f6b3) into main (9619985) will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7606      +/-   ##
==========================================
- Coverage   11.63%   10.38%   -1.26%     
==========================================
  Files          20       18       -2     
  Lines        1160      992     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1022      888     -134     
+ Partials        3        1       -2
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9619985...1d1f6b3. Read the comment docs.

@svenefftinge svenefftinge force-pushed the sefftinge/my-workspaces-7604 branch from 9fedc75 to 84f07c1 Compare January 14, 2022 09:00
@svenefftinge svenefftinge marked this pull request as ready for review January 14, 2022 09:00
@svenefftinge svenefftinge requested a review from a team January 14, 2022 09:00
@svenefftinge
Copy link
Member Author

svenefftinge commented Jan 14, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-sefftinge-my-workspaces-7604.2

@svenefftinge
[dashboard] single workspaces list
1d1f6b3 
reverts the multiple workspaces lists under teams and projects
reintroduces a single workspaces list that shows all my workspaces
@svenefftinge svenefftinge force-pushed the sefftinge/my-workspaces-7604 branch from 84f07c1 to 1d1f6b3 Compare January 14, 2022 11:00
@jldec jldec mentioned this pull request Jan 14, 2022
Closed
@jldec
Copy link
Contributor

jldec commented Jan 14, 2022

Approve of UX and design - hold for deeper code review
/hold

jldec
jldec approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX and design looks good.

@roboquat roboquat added the lgtm label Jan 14, 2022
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9467b25998c2e97580dcd12ab15da8ad2fcba7ea

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jldec

Associated issue: #7604

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JanKoehnlein
Copy link
Contributor

/unhold

LGTM code-wise

@roboquat roboquat merged commit 932a33a into main Jan 14, 2022
@roboquat roboquat deleted the sefftinge/my-workspaces-7604 branch January 14, 2022 14:38
@gtsiolis gtsiolis mentioned this pull request Jan 18, 2022
Closed
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 19, 2022
@gtsiolis gtsiolis mentioned this pull request Jan 20, 2022
Closed
@gtsiolis gtsiolis mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldec jldec jldec approved these changes

Assignees

@jldec jldec

Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard] Single View for *My* Workspaces
4 participants
@svenefftinge @jldec @roboquat @JanKoehnlein