Skip to content

Install gitpod.gitpod-theme as builtin extension #10079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented May 17, 2022

Description

The extension is already bundled when building vscode, this will only update the extension to a newer version if any exist.
If there's no access to openvsx for some reason (self-hosted case) bundled version will be used.

Fixes #9950

How to test

  1. Select insiders
  2. Open workspace
  3. Check gitpod theme is installed

Release Notes

NONE

The extension is already bundled when building vscode, this will only update the extension to a newer version if any exist.
If there's no access to openvsx for some reason (self-hosted case) bundled version will be used.
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

Works as expected

ps builtin code command
image image image

@roboquat roboquat merged commit b06842b into main May 18, 2022
@roboquat roboquat deleted the jp/gitpod-theme branch May 18, 2022 05:07
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the published gitpod theme in gitpod
3 participants