Skip to content

Gitpod theme as builtInExtensions #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2022
Merged

Gitpod theme as builtInExtensions #353

merged 1 commit into from
May 18, 2022

Conversation

jeanp413
Copy link
Member

Download Gitpod theme as builtInExtensions during build

@jeanp413 jeanp413 requested a review from andreafalzetti May 17, 2022 21:12
@andreafalzetti
Copy link

@jeanp413 code LGTM - is there a way to test?

@jeanp413
Copy link
Member Author

jeanp413 commented May 18, 2022

ah yeah this was related to gitpod-io/gitpod#10079 but Huiwen already approved 😄, I'll just merge it then.
In any case you could test from sources and see the gitpod theme is still there, you can just wait for the gitpod task to finish or cancel them and run them manually yarn watch to compile, ./scripts/code-server --without-connection-token to launch the server if you see the logs it will say it's downloading the gitpod-theme extension

@jeanp413 jeanp413 merged commit 3dd5bb0 into gp-code/main May 18, 2022
@jeanp413 jeanp413 deleted the jp/gitpod-theme branch May 18, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants