[image-builder-bob] Use separate auth for target and base #10094
Conversation
princerachit
force-pushed
the
prs/json-key-override
branch
2 times, most recently
from
6fdc65a to
d11912a
Compare
princerachit
force-pushed
the
prs/json-key-override
branch
from
d11912a to
aa2aaaa
Compare
|
/hold |
| @@ -92,6 +108,6 @@ func init() { | |||
| // These env vars start with `WORKSPACEKIT_` so that they aren't passed on to ring2 | |||
| proxyCmd.Flags().StringVar(&proxyOpts.BaseRef, "base-ref", os.Getenv("WORKSPACEKIT_BOBPROXY_BASEREF"), "ref of the base image") | |||
| proxyCmd.Flags().StringVar(&proxyOpts.TargetRef, "target-ref", os.Getenv("WORKSPACEKIT_BOBPROXY_TARGETREF"), "ref of the target image") | |||
| proxyCmd.Flags().StringVar(&proxyOpts.Auth, "auth", os.Getenv("WORKSPACEKIT_BOBPROXY_AUTH"), "authentication to use") | |||
| proxyCmd.Flags().StringVar(&proxyOpts.AdditionalAuth, "additional-auth", os.Getenv("WORKSPACEKIT_BOBPROXY_ADDITIONALAUTH"), "additional authentication to use") | |||
| proxyCmd.Flags().StringVar(&proxyOpts.BaseAuth, "base-auth", os.Getenv("WORKSPACEKIT_BOBPROXY_AUTH"), "authentication to use for base ref") | |||
There was a problem hiding this comment.
would this break any existing installs by any chance? (changing command line param names)
There was a problem hiding this comment.
I checked ops repo and gitpod repo but could not find any references. AFAIK image-builder-bob proxy is only run in the imagebuild pods which is started by image-builder-mk3. Since image-builder-mk3 it self does not use these flags, it is unlikely that these flags are used anywhere else and break existing installs.
|
/werft run 👍 started the job as gitpod-build-prs-json-key-override.5 |
|
/unhold I am going to merge this PR as some members of the team are at kubecon and it can take them few more days to come back. If this breaks anything we can revert this. |
roboquat
added
deployed: workspace
Description
Use terms such
baseandtargetto distinguish between image source (base) and built image (target).Use separate auth for target and base so that when the target and base images are both in the same registry provider, correct auth is used.
e.g. User wants to use an image from their private gcr but we want to push the built image to gitpod's private gcr.
Related Issue(s)
Fixes #10089
How to test
Follow Reproduce steps from this issue #10089. Error should not be reproducible.
I already tested this in the preview env of this branch.
Image builds
Workspace Starts
Release Notes
Documentation