Skip to content

Revert "[image-builder-bob] Use separate auth for target and base" #10225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2022
Merged

Revert "[image-builder-bob] Use separate auth for target and base" #10225

merged 1 commit into from
May 24, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented May 24, 2022 •
edited
Loading

Reverts #10094

Release Notes

NONE

@iQQBot iQQBot requested a review from a team May 24, 2022 16:33
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 24, 2022
kylos101
kylos101 approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Without doing this revert, we were unable to do image builds in staging and prod.

@sagor999
Copy link
Contributor

@princerachit we had to revert your PR because it broke image builder that is currently used in webapp cluster.

@roboquat roboquat merged commit 0899f4d into main May 24, 2022
@roboquat roboquat deleted the revert-10094-prs/json-key-override branch May 24, 2022 17:04
@princerachit
Copy link
Contributor

FYI #10235

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 25, 2022
@kylos101 kylos101 mentioned this pull request Jun 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iQQBot @sagor999 @princerachit @kylos101 @roboquat