Skip to content

[dev] Run gofmt after Go 1.19 upgrade #11958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2022
Merged

[dev] Run gofmt after Go 1.19 upgrade #11958

merged 2 commits into from
Aug 8, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Aug 8, 2022 •
edited
Loading

Description

Run gofmt in multiple source directories. This is necessary after upgrading to Go 1.19 (#11891).

As of Go 1.19, gofmt now formats godoc comments too; see here.

Related Issue(s)

Fixes the broken main build. See internal discussion here and here.

How to test

Werft is green again.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

Run gofmt
bd58018 
gofmt -w .

From the repository root.
@andrew-farries andrew-farries marked this pull request as ready for review August 8, 2022 12:48
@andrew-farries andrew-farries requested review from a team August 8, 2022 12:48
@github-actions github-actions bot added team: IDE team: devx team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Aug 8, 2022
@mrsimonemms mrsimonemms mentioned this pull request Aug 8, 2022
Merged
1 task
@andrew-farries
Copy link
Contributor Author

/hold

@andrew-farries
Copy link
Contributor Author

/unhold

jankeromnes
jankeromnes approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Werft if indeed green again -- thanks! 🎉 Rubber-stamping for team WebApp.

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Aug 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks, @andrew-farries 🙏

@roboquat roboquat merged commit 3c23517 into main Aug 8, 2022
@roboquat roboquat deleted the af/gofmt branch August 8, 2022 13:54
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production labels Aug 9, 2022
@andrew-farries andrew-farries mentioned this pull request Aug 10, 2022
Merged
1 task
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf approved these changes

@jankeromnes jankeromnes jankeromnes approved these changes

@andreafalzetti andreafalzetti andreafalzetti approved these changes

@vulkoingim vulkoingim vulkoingim approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production release-note-none size/L team: devx team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrew-farries @andreafalzetti @aledbf @jankeromnes @vulkoingim @roboquat