[dev] Run gofmt after Go 1.19 upgrade

components/common-go/baseserver/server.go

@@ -61,18 +61,18 @@ func New(name string, opts ...Option) (*Server, error) {
 // Server implements graceful shutdown making it suitable for usage in integration tests. See server_test.go.
 //
 // Server is composed of the following:
-// 	* Debug server which serves observability and debug endpoints
-//		- /metrics for Prometheus metrics
-//		- /pprof for Golang profiler
-//		- /ready for kubernetes readiness check
-//		- /live for kubernetes liveness check
-//	* (optional) gRPC server with standard interceptors and configuration
-//		- Started when baseserver is configured WithGRPCPort (port is non-negative)
-//		- Use Server.GRPC() to get access to the underlying grpc.Server and register services
-//	* (optional) HTTP server
-//		- Currently does not come with any standard HTTP middlewares
-//		- Started when baseserver is configured WithHTTPPort (port is non-negative)
-// 		- Use Server.HTTPMux() to get access to the root handler and register your endpoints
+//   - Debug server which serves observability and debug endpoints
+//   - /metrics for Prometheus metrics
+//   - /pprof for Golang profiler
+//   - /ready for kubernetes readiness check
+//   - /live for kubernetes liveness check
+//   - (optional) gRPC server with standard interceptors and configuration
+//   - Started when baseserver is configured WithGRPCPort (port is non-negative)
+//   - Use Server.GRPC() to get access to the underlying grpc.Server and register services
+//   - (optional) HTTP server
+//   - Currently does not come with any standard HTTP middlewares
+//   - Started when baseserver is configured WithHTTPPort (port is non-negative)
+//   - Use Server.HTTPMux() to get access to the root handler and register your endpoints
 type Server struct {
 	// Name is the name of this server, used for logging context
 	Name string

components/common-go/log/log.go

@@ -31,7 +31,8 @@ const (
 
 // OWI builds a structure meant for logrus which contains the owner, workspace and instance.
 // Beware that this refers to the terminology outside of wsman which maps like:
-//    owner = owner, workspace = metaID, instance = workspaceID
+//
+//	owner = owner, workspace = metaID, instance = workspaceID
 func OWI(owner, workspace, instance string) log.Fields {
 	return log.Fields{
 		OwnerField:     owner,
@@ -42,7 +43,8 @@ func OWI(owner, workspace, instance string) log.Fields {
 
 // LogContext builds a structure meant for logrus which contains the owner, workspace and instance.
 // Beware that this refers to the terminology outside of wsman which maps like:
-//    owner = owner, workspace = metaID, instance = workspaceID
+//
+//	owner = owner, workspace = metaID, instance = workspaceID
 func LogContext(owner, workspace, instance, project, team string) log.Fields {
 	logFields := log.Fields{}
 

components/ee/agent-smith/cmd/testtarget/main.go

@@ -15,6 +15,7 @@ func main() {
 }
 
 // don't inline to produce an elf entry
+//
 //go:noinline
 func agentSmithTestTarget() {
 	fmt.Println("something")

components/gitpod-cli/cmd/credential-helper.go

@@ -230,9 +230,11 @@ func walkProcessTree(pid int, fn pidCallbackFn) error {
 // - Private npm package
 //   - Create a private git repository for an npm package e.g https://github.com/jeanp413/test-private-package
 //   - Start a workspace, then run `npm install github:jeanp413/test-private-package` with and without permissions in the dashboard
+//
 // - Private npm package no access
 //   - Open this workspace https://github.com/jeanp413/test-gp-bug and run `npm install`
-//   - Observe NO notification with this message appears `Unknown repository '' Please grant the necessary permissions.`
+//   - Observe NO notification with this message appears `Unknown repository ” Please grant the necessary permissions.`
+//
 // - Clone private repo without permission
 //   - Start a workspace, then run `git clone 'https://gitlab.ebizmarts.com/ebizmarts/magento2-pos-api-request.git`, you should see a prompt ask your username and password, instead of `'gp credential-helper' told us to quit`
 func init() {

components/gitpod-protocol/go/websocket.go

@@ -39,7 +39,7 @@ var (
 	pingPeriod = (pongWait * 9) / 10
 )
 
-//NewWebsocketConnection converts a websocket.Conn into a net.Conn
+// NewWebsocketConnection converts a websocket.Conn into a net.Conn
 func NewWebsocketConnection(ctx context.Context, websocketConn *websocket.Conn, onStale func(staleErr error)) (*WebsocketConnection, error) {
 	ctx, cancel := context.WithCancel(ctx)
 	c := &WebsocketConnection{
@@ -90,8 +90,8 @@ func (c *WebsocketConnection) Wait() error {
 	return c.closeErr
 }
 
-//Read is not threadsafe though thats okay since there
-//should never be more than one reader
+// Read is not threadsafe though thats okay since there
+// should never be more than one reader
 func (c *WebsocketConnection) Read(dst []byte) (int, error) {
 	ldst := len(dst)
 	//use buffer or read new message

components/ide/jetbrains/image/status/main.go

@@ -379,24 +379,26 @@ func updateVMOptions(config *gitpod.GitpodConfig, alias string, content string)
 	return strings.Join(vmoptions, "\n") + "\n"
 }
 
-/**
-{
-  "buildNumber" : "221.4994.44",
-  "customProperties" : [ ],
-  "dataDirectoryName" : "IntelliJIdea2022.1",
-  "launch" : [ {
-    "javaExecutablePath" : "jbr/bin/java",
-    "launcherPath" : "bin/idea.sh",
-    "os" : "Linux",
-    "startupWmClass" : "jetbrains-idea",
-    "vmOptionsFilePath" : "bin/idea64.vmoptions"
-  } ],
-  "name" : "IntelliJ IDEA",
-  "productCode" : "IU",
-  "svgIconPath" : "bin/idea.svg",
-  "version" : "2022.1",
-  "versionSuffix" : "EAP"
-}
+/*
+*
+
+	{
+	  "buildNumber" : "221.4994.44",
+	  "customProperties" : [ ],
+	  "dataDirectoryName" : "IntelliJIdea2022.1",
+	  "launch" : [ {
+	    "javaExecutablePath" : "jbr/bin/java",
+	    "launcherPath" : "bin/idea.sh",
+	    "os" : "Linux",
+	    "startupWmClass" : "jetbrains-idea",
+	    "vmOptionsFilePath" : "bin/idea64.vmoptions"
+	  } ],
+	  "name" : "IntelliJ IDEA",
+	  "productCode" : "IU",
+	  "svgIconPath" : "bin/idea.svg",
+	  "version" : "2022.1",
+	  "versionSuffix" : "EAP"
+	}
 */
 type ProductInfo struct {
 	Version string `json:"version"`

components/licensor/typescript/ee/main.go

@@ -20,6 +20,7 @@ var (
 )
 
 // Init initializes the global license evaluator from an environment variable
+//
 //export Init
 func Init(key *C.char, domain *C.char) (id int) {
 	id = nextID
@@ -36,6 +37,7 @@ func Init(key *C.char, domain *C.char) (id int) {
 }
 
 // GetLicenseData returns the info about license for the admin dashboard
+//
 //export GetLicenseData
 func GetLicenseData(id int) (licData *C.char, ok bool) {
 	e, ok := instances[id]
@@ -54,6 +56,7 @@ func GetLicenseData(id int) (licData *C.char, ok bool) {
 }
 
 // Validate returns false if the license isn't valid and a message explaining why that is.
+//
 //export Validate
 func Validate(id int) (msg *C.char, valid bool) {
 	e, ok := instances[id]
@@ -66,6 +69,7 @@ func Validate(id int) (msg *C.char, valid bool) {
 }
 
 // Enabled returns true if a license enables a feature
+//
 //export Enabled
 func Enabled(id int, feature *C.char, seats int) (enabled, ok bool) {
 	e, ok := instances[id]
@@ -77,6 +81,7 @@ func Enabled(id int, feature *C.char, seats int) (enabled, ok bool) {
 }
 
 // HasEnoughSeats returns true if the license supports at least the given number of seats.
+//
 //export HasEnoughSeats
 func HasEnoughSeats(id int, seats int) (permitted, ok bool) {
 	e, ok := instances[id]
@@ -88,6 +93,7 @@ func HasEnoughSeats(id int, seats int) (permitted, ok bool) {
 }
 
 // Inspect returns the license information this evaluator holds.
+//
 //export Inspect
 func Inspect(id int) (lic *C.char, ok bool) {
 	e, ok := instances[id]
@@ -105,6 +111,7 @@ func Inspect(id int) (lic *C.char, ok bool) {
 }
 
 // Dispose removes/disposes an instance formerly created using Init. If the id does not exist, nothing happens.
+//
 //export Dispose
 func Dispose(id int) {
 	delete(instances, id)

components/proxy/plugins/logif/caddyfile.go

@@ -13,9 +13,10 @@ import (
 // UnmarshalCaddyfile sets up the module form Caddyfile tokens.
 //
 // Syntax:
-// if {
-//     "<expression>"
-// } [<encoder>]
+//
+//	if {
+//	    "<expression>"
+//	} [<encoder>]
 //
 // The <expression> must be on a single line.
 // Refer to `lang.Lang` for its syntax.

components/proxy/plugins/workspacedownload/workspace_download.go

@@ -171,4 +171,4 @@ func (n *noBufferWriter) Write(p []byte) (written int, err error) {
 	}
 
 	return
-}
+}

components/registry-facade/ca-updater/Dockerfile

@@ -2,7 +2,7 @@
 # Licensed under the GNU Affero General Public License (AGPL).
 # See License-AGPL.txt in the project root for license information.
 
-FROM ubuntu:21.04
+FROM ubuntu:22.04
 
 COPY install-packages /usr/bin
 

components/workspacekit/cmd/rings.go

@@ -623,7 +623,8 @@ var (
 // That's how configMaps and secrets behave in Kubernetes.
 //
 // Note/Caveat: configMap or secret volumes with a subPath do not behave as described above and will not be recognised by this function.
-//              in those cases you'll want to use GITPOD_WORKSPACEKIT_BIND_MOUNTS to explicitely list those paths.
+//
+//	in those cases you'll want to use GITPOD_WORKSPACEKIT_BIND_MOUNTS to explicitely list those paths.
 func findBindMountCandidates(procMounts io.Reader, readlink func(path string) (dest string, err error)) (mounts []string, err error) {
 	scanner := bufio.NewScanner(procMounts)
 	for scanner.Scan() {

components/ws-daemon/pkg/cpulimit/cpulimit.go

@@ -274,10 +274,12 @@ type Bucket struct {
 // BucketLimiter limits CPU use based on different "pots of CPU time".
 // The current limit is decided by the current bucket which is taken in order.
 // For example:
-//    buckets = [ { Budget: 50, Limit: 20 }, { Budget: 20, Limit: 10 }, { Budget: 0, Limit: 5 } ]
-//    budgetSpent = totalBudget - budgetLeft == 65
-//    then the current limit is 10, because we have spent all our budget from bucket 0, and are currently
-//    spending from the second bucket.
+//
+//	buckets = [ { Budget: 50, Limit: 20 }, { Budget: 20, Limit: 10 }, { Budget: 0, Limit: 5 } ]
+//	budgetSpent = totalBudget - budgetLeft == 65
+//	then the current limit is 10, because we have spent all our budget from bucket 0, and are currently
+//	spending from the second bucket.
+//
 // The last bucket's Budget is always ignored and becomes the default limit if all other
 // buckets are used up.
 // If the list of buckets is empty, this limiter limits to zero.

components/ws-daemon/pkg/iws/iws.go

@@ -934,7 +934,8 @@ func (wbs *InWorkspaceServiceServer) WriteIDMapping(ctx context.Context, req *ap
 //
 // <container-cgorup>  drwxr-xr-x 3 root      root
 // └── workspace       drwxr-xr-x 5 gitpodUid gitpodGid
-//     └── user        drwxr-xr-x 5 gitpodUid gitpodGid
+//
+//	└── user        drwxr-xr-x 5 gitpodUid gitpodGid
 func (wbs *InWorkspaceServiceServer) EvacuateCGroup(ctx context.Context, req *api.EvacuateCGroupRequest) (*api.EvacuateCGroupResponse, error) {
 	unified, err := cgroups.IsUnifiedCgroupSetup()
 	if err != nil {

components/ws-manager/pkg/clock/clock.go

@@ -12,17 +12,19 @@ import (
 )
 
 // This clock roughly implements a Hybrid Logical Clock (HLC) as described in
-//   Logical Physical Clocks and Consistent Snapshots in Globally Distributed Databases
-//   Kulkarni et al.
-//   https://cse.buffalo.edu/tech-reports/2014-04.pdf
+//
+//	Logical Physical Clocks and Consistent Snapshots in Globally Distributed Databases
+//	Kulkarni et al.
+//	https://cse.buffalo.edu/tech-reports/2014-04.pdf
 //
 // This implementation is very much geared towards single process use, yet still
 // protects us from the funny bits of physical wall time, e.g. clock skew or time
 // running backwards. Also, this implementation is naively synchronised using a simple mutex.
 //
 // In the future, if we ever make ws-manager properly distributed, we might want
 // to take inspiration from cockroachDB's implementation:
-//     https://github.com/cockroachdb/cockroach/blob/master/pkg/util/hlc/hlc.go
+//
+//	https://github.com/cockroachdb/cockroach/blob/master/pkg/util/hlc/hlc.go
 type HLC struct {
 	physicalTime          func() uint64
 	backwardsFlowReporter func(diff uint64)
@@ -37,8 +39,9 @@ type HLC struct {
 
 // System takes the wall time from the actual system time.
 // Beware: when using the clock wall time, it's a good idea to wait out
-//         the maximum expected real wall time skew, e.g. as imposed by
-//         NTP. time.Sleep(2*time.Second) should be enough in most cases.
+//
+//	the maximum expected real wall time skew, e.g. as imposed by
+//	NTP. time.Sleep(2*time.Second) should be enough in most cases.
 func System() *HLC {
 	return &HLC{
 		physicalTime: func() uint64 { return uint64(time.Now().Unix()) },
@@ -59,7 +62,8 @@ const (
 // ReportBackwardsTime registers a reporter which gets called when the wall time
 // does not increase monotonously.
 // Beware: this function is not synchronised with Tick() and must not be called
-//         concurrently.
+//
+//	concurrently.
 func (c *HLC) ReportBackwardsTime(r func(diff uint64)) {
 	c.backwardsFlowReporter = r
 }

components/ws-manager/pkg/manager/internal/workpool/workpool.go

@@ -30,7 +30,6 @@ import (
 // Why not use kubernetes/client-go/workqueue?
 // We have different requirements than the workqueue. The Kubernetes workqueue cares about the order/
 // execution of single items. We care about the order of several items grouped by some factor.
-//
 type EventWorkerPool struct {
 	WorkOn func(watch.Event)
 

components/ws-manager/pkg/manager/manager.go

@@ -863,6 +863,7 @@ func (m *Manager) findWorkspacePod(ctx context.Context, workspaceID string) (*co
 }
 
 // getPodID computes the pod ID from a workpace ID
+//
 //nolint:unused,deadcode
 func getPodID(workspaceType, workspaceID string) string {
 	return fmt.Sprintf("%s-%s", strings.TrimSpace(strings.ToLower(workspaceType)), strings.TrimSpace(workspaceID))