Skip to content

[UBP] Extract common UBP configuration components #12732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Extract common React components that will be used on both the team settings and user settings pages to configure usage based pricing. Specifically:

image

and:

image

These components will be re-used in a later PR when they are added to the individual user settings page.

Related Issue(s)

Part of #12685

How to test

  • Create a new team in the preview environment whose name contains 'Gitpod'.
  • Configure usage based pricing for the new team (via its settings page).

The setup should work correctly as before, with a new customer created in Stripe with the correct team id in the customer's metadata.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! But I couldn't test it because no preview env was deployed. 🤷

@roboquat roboquat merged commit b663b56 into main Sep 7, 2022
@roboquat roboquat deleted the af/extract-common-ubp-components branch September 7, 2022 11:43
@andrew-farries
Copy link
Contributor Author

andrew-farries commented Sep 7, 2022

Code LGTM! But I couldn't test it because no preview env was deployed. 🤷

Not sure what happened there, but the follow up PR (#12733) that uses these components does have a preview env.

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants