-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[UBP] Add placeholder billing configuration UI to the user settings page #12733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/hold because it's based on #12732 |
/werft run with-preview with-payment 👍 started the job as gitpod-build-af-placeholder-individual-user-ubp-ui.1 |
/werft run with-preview with-payment 👍 started the job as gitpod-build-af-placeholder-individual-user-ubp-ui.2 |
c0e6bc6
to
2f4a219
Compare
172006f
to
95623b0
Compare
@andrew-farries and @jankeromnes, what's the state of this PR? And more interestingly, how does this relate to #12684? Is it already covered in here? If yes, please assign accordingly. If not, are you going to continue with that? |
I'm still hoping to land this soon. All review comments have been addressed. The usage limit for individuals (#12684) I consider to be part of #12685 as the UI for configuring billing for individuals also includes the UI to set usage limits. I've assigned #12684 to myself. |
95623b0
to
4eeae67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for iterating on this! 👍 Now looks perfect to me 🎯 and also works as advertised.
(It's even possible to create a customer as a User, however since the User Billing page doesn't yet handle the Stripe redirection and doesn't call subscribeUserToStripe
, we're not attaching credit cards or creating subscriptions for users yet -- unrelated to this PR / good as follow-up)
/unhold |
Description
Building on #12732 which extracted the components to make them reusable, add the UBP configuration UI widgets to the individual user billing page:
The 'Upgrade billing' button doesn't work yet. This is fine to merge as-is because only people opted into usage based billing will see the UI (currently only Gitpod team members).
Related Issue(s)
Part of #12685
How to test
Visit your user settings page and see the placeholder UI
Release Notes
Documentation
Werft options: