[ws-manager-bridge] Add application_cluster field to cluster service List RPC response message
#13940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
added 2 commits
October 18, 2022 12:31
And regenerate gRPC code.
Populate the new field added to the gRPC message in the parent commit.
andrew-farries
force-pushed
the
af/add-app-cluster-in-list-server-response
branch
from
cb43e65 to
161018a
Compare
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
As part of #9198 we want to start syncing the
d_b_workspace_clustertable withdb-sync.Currently, the table differs between US and EU regions because each table contains only the data relevant to that region. For example, in the EU table, the
eu70workspace cluster is marked asavailableand theus70cluster iscordoned. In the US clustereu70iscordonedandus70isavailable.In order to sync the table we need to get to a point where there is no difference in the data in the table between EU and US regions.
To do that we will introduce a new field in the table called
applicationClusterwhich records the name of the application cluster to which the record belongs. Thus, for each workspace cluster there will be two rows in Gitpod SaaS:Effectively the new
applicationClustercolumn gives the table an extra dimension so that we can combine both tables (EU and US) into one.#13722 added the column to the table and made
gpctlfill the value whengpctl registering a new workspace cluster. The value is taken from theGITPOD_INSTALLATION_SHORTNAMEenvironment variable inws-manager-bridge.Add a new
applicationClusterfield to theListResponsemessage in thews-manager-bridgeClusterServiceRPC service and populate the new field in the server implementation.Related Issue(s)
Part of #9198 and #13800
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide