Skip to content

[gpctl] Show application cluster in gpctl clusters list output #13941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Oct 18, 2022

Description

Context As part of #9198 we want to start syncing the `d_b_workspace_cluster` table with `db-sync`.

Currently, the table differs between US and EU regions because each table contains only the data relevant to that region. For example, in the EU table, the eu70 workspace cluster is marked as available and the us70 cluster is cordoned. In the US cluster eu70 is cordoned and us70 is available.

In order to sync the table we need to get to a point where there is no difference in the data in the table between EU and US regions.

To do that we will introduce a new field in the table called applicationCluster which records the name of the application cluster to which the record belongs. Thus, for each workspace cluster there will be two rows in Gitpod SaaS:

name applicationCluster url tls state ...
eu70 eu02 url tls info available ...
eu70 us02 url tls info cordoned ...

Effectively the new applicationCluster column gives the table an extra dimension so that we can combine both tables (EU and US) into one.

#13722 added the column to the table and made gpctl fill the value when gpctl registering a new workspace cluster. The value is taken from the GITPOD_INSTALLATION_SHORTNAME environment variable in ws-manager-bridge.

Add the application cluster for the workspace cluster to the output of gpctl clusters list:

image

The List RPC was extended in #13940 to add the extra application_cluster field in the response message.

Related Issue(s)

Part of #9198 and #13800

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@andrew-farries andrew-farries requested a review from a team October 18, 2022 10:04
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 18, 2022
@andrew-farries andrew-farries force-pushed the af/add-app-cluster-in-list-server-response branch from cb43e65 to 161018a Compare October 18, 2022 12:32
@andrew-farries andrew-farries requested a review from a team October 18, 2022 12:32
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 18, 2022
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Oct 18, 2022
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Oct 18, 2022
@andrew-farries andrew-farries force-pushed the af/show-app-cluster-in-gpctl branch from babd6a6 to 01187a8 Compare October 18, 2022 13:16
@andrew-farries andrew-farries removed the request for review from a team October 18, 2022 13:16
@jenting
Copy link
Contributor

jenting commented Oct 18, 2022

Is the application cluster output like eu71 or us71?

@andrew-farries
Copy link
Contributor Author

Is the application cluster output like eu71 or us71?

In the EU the application cluster is called eu02 and in the US it's us02.

Base automatically changed from af/add-app-cluster-in-list-server-response to main October 18, 2022 14:01
@andrew-farries andrew-farries force-pushed the af/show-app-cluster-in-gpctl branch from 01187a8 to af949cd Compare October 19, 2022 07:24
@roboquat roboquat merged commit 890ebc3 into main Oct 19, 2022
@roboquat roboquat deleted the af/show-app-cluster-in-gpctl branch October 19, 2022 07:34
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants