Tag VS Code images with version

[filiptronicek]

Description

Adds the io.gitpod.ide.commit and io.gitpod.ide.version labels to all images for VS Code built inside of this repository. This will allow us to add an interface on Server API through ide-service.

How to test

1. Go to the Werft job results [link]
2. Copy the third docker image link
   
3. Install OCI tool within a workspace (could also do locally): go install github.com/csweichel/oci-tool@latest
4. Execute oci-tool fetch image IMAGE_FROM_STEP_2 | jq .config.Labels and check whether both attributes are present

Release Notes

NONE

Werft options:

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-integration-tests=all
  Valid options are all, workspace, webapp, ide

[mustard-mh]

Note another place to change for code image build. XD

[mustard-mh]

Can't we get this from code build(building process(package.json) or result (oci-tool))? instead of changing codes?

[akosyakov]

Unfortunately image label cannot be computed during Docke build. We have to provide it via arg

[mustard-mh]

Why not do it like code-nightly do in this PR https://github.com/gitpod-io/gitpod/pull/14055/files#diff-3a4804782c8876a5e55d41725ccd6494495fcd585f75559bf4e1953ba8db5997R36-R37?

codeVersion=$(curl https://github.com/raw/gitpod-io/openvscode-server/$headCommit/package.json | jq .version)
leeway build -Dversion=nightly -DimageRepoBase=eu.gcr.io/gitpod-core-dev/build -DcodeCommit=$headCommit -DcodeVersion=$codeVersion -DcodeQuality=insider .:docker

[akosyakov]

How would you do it in WORKSPACE.yaml for stable? Please feel free to send a PR against this PR.

[jeanp413]

@akosyakov @filiptronicek there's docker-build-options in leeway

[mustard-mh]

This is the same as the implementation here, we have no way to get the version at docker build time (we checkout openvscode-server only at docker build time)

Although leeway can't do this, we can use the github raw file api to get the version number and pass it to leeway before the werft job starts leeway.
i.e. here

gitpod/.werft/jobs/build/build-and-publish.ts

Lines 44 to 57 in cb83111

	if (publishRelease) {
	exec(`gcloud auth activate-service-account --key-file "/mnt/secrets/gcp-sa-release/service-account.json"`);
	}
	const buildArguments = Object.entries({
	version: version,
	removeSources: "false",
	imageRepoBase: imageRepo,
	localAppVersion: localAppVersion,
	SEGMENT_IO_TOKEN: process.env.SEGMENT_IO_TOKEN,
	REPLICATED_API_TOKEN: process.env.REPLICATED_API_TOKEN,
	REPLICATED_APP: process.env.REPLICATED_APP,
	npmPublishTrigger: publishToNpm ? Date.now().toString() : "false",
	}).map(([key, value]) => `-D${key}=${value}`).join(" ");

But we can merge this PR first, and do a follow up PR

[mustard-mh]

I am doing rebase this PR to main, and build vscode image

[jeanp413]

@mustard-mh what do you mean just pass the version like this --docker-build-options="label=foo,label=bar" in code-nightly.yml

[mustard-mh]

OK build success, let's we merge it, and change code stable image in next PR

[iQQBot]

It works as expected, could you add a commit to change CodeIDEImageStableVersion ?

[filiptronicek]

If you take at the last job, you can see it fails correctly:

[mustard-mh]

LGTM