Add IDE versions to the dashboard #15139

filiptronicek · 2022-12-03T10:41:12Z

Description

This PR is simply adding versions below the icons of all IDEs in the IDE switcher component (used during on-boarding and always available in the user preferences).

This is partially a lie because we don't associate VS Code Desktop with a version, but it holds true for the rest.

It's a relatively easy win because we:

Already tag all newly-built IDE images with their version strings (Label JetBrains IDE images with their versions #15082, Tag VS Code images with version #14055)
We already implemented the functionality in ide-service so that it returns the IDE versions along the IDE options (Add IDE versions to ide service #15081)

With this we can do two things at once:

keep our users informed what versions we use right from the Dashboard (good for checking new versions with bug fixes and features)
makes it easier for us to check that our IDEs are at their correct versions when releasing them at IDE (the team).

How to test

Go to the preview environment and sign in
You should be greeted with a modal with the IDEs and their versions, you can also visit the user prefs to see it.

Release Notes

Add versions of all the supported IDEs to the Preferences page

Documentation

Werft options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

werft-gitpod-dev-com · 2022-12-03T10:41:25Z

started the job as gitpod-build-ft-add-ide-versions-dashboard.1 because the annotations in the pull request description changed
(with .werft/ from main)

easyCZ · 2022-12-05T09:04:06Z

components/dashboard/src/settings/SelectIDE.tsx

+function renderIdeOption(
+    option: IDEOption,
+    selected: boolean,
+    version: IDEOption["imageVersion"],


Wouldn't the version already be inside the option: IDEOption param?

option has 2 versions stable and latest, passed version is a selection one of another depending on a user choice (line 98 above)

easyCZ · 2022-12-05T09:04:08Z

components/dashboard/src/settings/SelectIDE.tsx

            // TODO: Compatible with ide-config not deployed, need revert after ide-config deployed
-            delete ideopts.options["code-latest"];
-            delete ideopts.options["code-desktop-insiders"];
+            delete ideOptions.options["code-latest"];
+            delete ideOptions.options["code-desktop-insiders"];


What does this relate to? Can we remove this logic?

yes, it can be removed already cc @mustard-mh

akosyakov · 2022-12-05T11:26:28Z

@filiptronicek very nice job ⭐

@mustard-mh Could you test please it to bring it in, looking forward! 🚀

gtsiolis · 2022-12-05T11:29:35Z

/werft run

👍 started the job as gitpod-build-ft-add-ide-versions-dashboard.7
(with .werft/ from main)

easyCZ

LGTM

/hold for you to merge when ready

gtsiolis

Seems like this breaks the dashboard UX. ❗

Modal (Signing up)	Preferences (User Settings)

gtsiolis · 2022-12-05T11:48:18Z

Regarding the comment above in #15139 (review), force reloading helped, not sure if something didn't load ok on the first run. 🤷 Cc @filiptronicek

gtsiolis · 2022-12-05T11:51:14Z

components/dashboard/src/settings/SelectIDE.tsx

+function renderIdeOption(
+    option: IDEOption,
+    selected: boolean,
+    version: IDEOption["imageVersion"],


question: When selecting the latest release, VS Code version remains the same. Is this expected?

I think here it's because in preview environments, we just use the stable version as Insiders. Should be expected

@iQQBot please correct me if I'm wrong here 😄 🙏

Thanks, @filiptronicek! OK, let's see how this behaves in production, then. 🎣

components/dashboard/src/settings/SelectIDE.tsx

gtsiolis

Leaving one last comment, following up from a relevant discussion (internal), it should be ok to merge this and create follow-up issues or PRs for the outstanding design details.

Looping in @filiptronicek, @mustard-mh, and @akosyakov to release the hold break if this sounds ok. 🏓

Cross-posting for visibility:

Maybe using a different label variant to not associate these two kinds of information.

mustard-mh

Code, UX LGTM.

Tested with preview env, worked like a charm 🎉

Seems like this breaks the dashboard UX. ❗

@gtsiolis Maybe related to network issue? you can check your DevTool Console and Network tabs next time you faced it. 🙏

ide-service will need to fetch and process image information when it first start, during this time, server will not get data. So it can happen also when server has no cache for it yet, and ide-service is starting. But it should not be your case, as no one is going to restart it.

We need to handle healthy check in ide-service properly.

akosyakov · 2022-12-06T08:39:12Z

Can be unhold?

filiptronicek · 2022-12-06T14:08:38Z

/unhold

gtsiolis · 2022-12-06T16:02:48Z

@filiptronicek Did you want me to re-review the UX changes in #15139 (comment)? Seems like not much changed from UX perspective.

akosyakov · 2022-12-06T16:52:02Z

@gtsiolis I guess you need approve to unblock

Not sure why it is not mergeable

approved

filiptronicek · 2022-12-06T17:03:17Z

Sorry for the confusion, @gtsiolis 🙏. The re-request was triggered because I thought it would unblock merging, it seems that just dismissing your review did the trick (thanks Anton!).

gtsiolis · 2022-12-06T17:05:01Z

Thanks @filiptronicek & @akosyakov!

Opened follow-up issue #15194 to keep track of the design nitpicks based on our discussion (internal).

filiptronicek self-assigned this Dec 3, 2022

roboquat added release-note do-not-merge/work-in-progress size/M labels Dec 3, 2022

filiptronicek force-pushed the ft/add-ide-versions-dashboard branch from 5382413 to fffef66 Compare December 3, 2022 12:14

Add versions to the dashboard

c5a4f9c

filiptronicek force-pushed the ft/add-ide-versions-dashboard branch from fffef66 to c5a4f9c Compare December 3, 2022 12:28

filiptronicek marked this pull request as ready for review December 3, 2022 12:51

filiptronicek requested a review from a team December 3, 2022 12:51

roboquat removed the do-not-merge/work-in-progress label Dec 3, 2022

github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 3, 2022

easyCZ reviewed Dec 5, 2022

View reviewed changes

easyCZ approved these changes Dec 5, 2022

View reviewed changes

roboquat added the do-not-merge/hold label Dec 5, 2022

gtsiolis previously requested changes Dec 5, 2022

View reviewed changes

gtsiolis reviewed Dec 5, 2022

View reviewed changes

components/dashboard/src/settings/SelectIDE.tsx Show resolved Hide resolved

gtsiolis reviewed Dec 5, 2022

View reviewed changes

Remove outdated logic with now obsolete clients

b2a0a9b

mustard-mh approved these changes Dec 5, 2022

View reviewed changes

filiptronicek added the component: dashboard label Dec 6, 2022

roboquat removed the do-not-merge/hold label Dec 6, 2022

filiptronicek requested a review from gtsiolis December 6, 2022 14:53

roboquat merged commit 0f97962 into main Dec 6, 2022

roboquat deleted the ft/add-ide-versions-dashboard branch December 6, 2022 16:53

gtsiolis mentioned this pull request Dec 6, 2022

Update the design of the editor selection cards #15194

Closed

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 7, 2022

gtsiolis mentioned this pull request Dec 12, 2022

Display IDE detail versions #8816

Closed

Add IDE versions to the dashboard #15139

Add IDE versions to the dashboard #15139

Uh oh!

Conversation

filiptronicek commented Dec 3, 2022 • edited by atduarte Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How to test

Release Notes

Documentation

Werft options:

Uh oh!

werft-gitpod-dev-com bot commented Dec 3, 2022

Uh oh!

easyCZ Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

akosyakov Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

easyCZ Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

akosyakov Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

akosyakov commented Dec 5, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gtsiolis commented Dec 5, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

easyCZ left a comment

Choose a reason for hiding this comment

Uh oh!

gtsiolis left a comment

Choose a reason for hiding this comment

Uh oh!

gtsiolis commented Dec 5, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gtsiolis Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

filiptronicek Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

gtsiolis Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gtsiolis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mustard-mh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akosyakov commented Dec 6, 2022

Uh oh!

filiptronicek commented Dec 6, 2022

Uh oh!

gtsiolis commented Dec 6, 2022

Uh oh!

akosyakov commented Dec 6, 2022

Uh oh!

filiptronicek commented Dec 6, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gtsiolis commented Dec 6, 2022

Uh oh!

Uh oh!

filiptronicek commented Dec 3, 2022 •

edited by atduarte

Loading

akosyakov Dec 5, 2022 •

edited

Loading

akosyakov commented Dec 5, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Dec 5, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Dec 5, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment •

edited

Loading

mustard-mh left a comment •

edited

Loading

filiptronicek commented Dec 6, 2022 •

edited by werft-gitpod-dev-com bot

Loading