[Usage-based] Untie paid Stripe subscriptions from calendar months

[jankeromnes]

Description

• Address follow-up code nits from Use the actual billing cycle dates in all usage-based Billing pages #14485
• Don't specify a custom billing anchor date when creating new Stripe subscriptions
• Always specify both a billingCycleStart and nextBillingTime on all Cost Centers

Related Issue(s)

Fixes #14700

How to test

1. Create a team called "Gitpod [Something]"
2. Upgrade that team to usage-based on Stripe by adding a payment method (e.g. 4242 4242 4242 4242, 4/24, 424)
3. Once active, the Billing UI should show the dates "(today) - (today + 1 month)"
   a. It should not show "(first day of month)" or "(last day of month)" as was the case before
   a. Hint: You can hover over the billing cycle dates to see the exact millisecond (both boundaries should be on the same second, one month apart)

Release Notes

NONE

Documentation

Werft options:

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-integration-tests=all
  Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

[werft-gitpod-dev-com]

started the job as gitpod-build-jx-adjust-monthly-cycles.1 because the annotations in the pull request description changed
(with .werft/ from main)

[easyCZ]

LGTM.
/hold for Qs

How will you update the existing Stripe CostCenter records?

Also, the ResetJob doesn't touch any Stripe CostCenters, so the value in https://github.com/gitpod-io/gitpod/pull/14705/files#diff-3d0d7f3b128d2677bfd96f23f31f3f8935756b31537aad113d58eb08ac654cb1R190 will be out of date after the first subscription to stripe.

[jankeromnes]

How will you update the existing Stripe CostCenter records?

That's the beauty of it -- we don't 😇

• All existing Stripe CostCenters are firmly anchored to calendar months. They may not have a NextBillingTime, or even a BillingCycleStart, but that doesn't matter, because the UI falls back to calendar months and always shows the right dates 👍

• Only new Stripe CostCenters can be anchored on any arbitrary date after this PR is deployed. And, thankfully, in the same PR, we also make sure that any new Stripe CostCenter has both a NextBillingTime and a BillingCycleStart 👍

Thus, the UI will always show the right dates, no matter if old or new Stripe CostCenter. 🪄

Also, the ResetJob doesn't touch any Stripe CostCenters, so the value in https://github.com/gitpod-io/gitpod/pull/14705/files#diff-3d0d7f3b128d2677bfd96f23f31f3f8935756b31537aad113d58eb08ac654cb1R190 will be out of date after the first subscription to stripe.

Aha, interesting, I assumed that it would create a new Stripe CostCenter. If not, this sounds like a good follow-up issue. 💡

[jankeromnes]

Artemis 1 is go for launch! 🚀 🌖

/unhold

[easyCZ]

Aha, interesting, I assumed that it would create a new Stripe CostCenter. If not, this sounds like a good follow-up issue. 💡

This was by design at that time, because the Stripe Invoice webhook is what triggers a spending limit reset and the CostCenter was meant to remain the same. Nothing stops us from creating a new CostCenter, but it should happen in response to the Stripe invoice, rather than when the billing period "ends" in our system.