[ubp] reset usage on chargebee cancellation #15362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-sefftinge-ubp-handle-chargebee-15055.1 because the annotations in the pull request description changed |
svenefftinge
force-pushed
the
sefftinge/ubp-handle-chargebee-15055
branch
2 times, most recently
from
1ba9010 to
a5d366c
Compare
svenefftinge
force-pushed
the
sefftinge/ubp-handle-chargebee-15055
branch
from
a5d366c to
e83cd4f
Compare
github-actions
bot
added
team: SID
team: webapp
jankeromnes
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Many thanks! Code changes look good to me (modulo one nit), and they appear to work flawlessly! 🎯
I've tested:
- Accruing usage (visible in
/usageand the/billingbalance) - Cancelling a Chargebee TeamSubscription2 -- worked flawlessly ✅
- Cancelling a legacy Chargebee TeamSubscription (of which one seat was assigned to me) -- worked flawlessly ✅
- Cancelling a personal Chargebee plan -- worked flawlessly ✅
Holding for one optional nit.
/hold
components/ee/payment-endpoint/src/accounting/team-subscription-service.ts
Outdated
Show resolved
Hide resolved
…n-service.ts Co-authored-by: Jan Keromnes <[email protected]>
|
/unhold |
liam-j-bennett
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a credit note for negative balance for users that are canceled (team slot or individual), so that those users start with a zero balance.
I've tested teamsubscription, teamsubscription2, individual subscription.
Related Issue(s)
Fixes #15055
How to test
Note: the
AddUsageCreditNoteendpoint uses entire credits and can't handle creditcents. So if balance is 12.34 the credit note will be 12.Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh