Skip to content

Update prebuild and incremental prebuild emojis #16110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update prebuild and incremental prebuild emojis #16110

wants to merge 1 commit into from

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jan 30, 2023 •
edited by jeanp413
Loading

Description

An attempt to resolve #15508, see relevant comment in #15508 (comment).

Related Issue(s)

Fixes #15508

How to test

Add a project and open the logs of a successful prebuild.

Release Notes

Update prebuild and incremental prebuild emojis

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 30, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.2
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jan 30, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.3
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 3, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.4
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 3, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.5
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.6 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 3, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.7
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 8, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.8
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 10, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.9
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 13, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.10
(with .werft/ from main)

@gtsiolis gtsiolis force-pushed the gt/update-prebuild-and-incremental-prebuild-emojis branch from fa32177 to 94f1cbd Compare February 14, 2023 13:12
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 14, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.12
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 14, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true recreate-vm=true with-preview=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.13
(with .werft/ from main)

@gtsiolis gtsiolis marked this pull request as ready for review February 14, 2023 16:44
@gtsiolis gtsiolis requested a review from a team February 14, 2023 16:44
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 15, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Ready-For-Review 🏓

@gtsiolis gtsiolis force-pushed the gt/update-prebuild-and-incremental-prebuild-emojis branch from 94f1cbd to e889a6a Compare February 16, 2023 10:06
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.15 because the annotations in the pull request description changed
(with .werft/ from main)

gtsiolis
gtsiolis commented Feb 16, 2023
View reviewed changes
components/supervisor/pkg/supervisor/tasks.go Outdated
@@ -498,14 +498,14 @@ func (tm *tasksManager) watch(task *task, term *terminal.Term) {
duration := ""
if elapsed >= 1*time.Minute {
elapsedInMinutes := strconv.Itoa(int(math.Round(elapsed.Minutes())))
duration = "⏱️ Well done on saving " + elapsedInMinutes + " minute"
duration = "⏱️\bWell done on saving " + elapsedInMinutes + " minute"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Does \b work? I couldn't test this with a prebuild in the preview environment. 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does space doesn't work 🤔 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe an xterm issue 🤔

Copy link
Contributor Author

@gtsiolis gtsiolis Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jeanp413! I highlighted this because I could not test it in the preview environment. Maybe it's working just fine. Do you think it's safe to merge this as is and see how it renders in production?

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 16, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.16
(with .werft/ from main)

@jeanp413
Copy link
Member

jeanp413 commented Feb 16, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run recreate-vm

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.17
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.18 because the annotations in the pull request description changed
(with .werft/ from main)

@jeanp413
Copy link
Member

jeanp413 commented Feb 16, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.19
(with .werft/ from main)

@jeanp413
Copy link
Member

jeanp413 commented Feb 17, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.20
(with .werft/ from main)

@jeanp413
Copy link
Member

/hold

@gtsiolis gtsiolis force-pushed the gt/update-prebuild-and-incremental-prebuild-emojis branch from e889a6a to fb9a339 Compare February 17, 2023 10:10
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 17, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true recreate-vm=true with-preview=true

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.22
(with .werft/ from main)

@jeanp413
Copy link
Member

@gtsiolis doesn't work 😞

image

@jeanp413
Copy link
Member

image

@jeanp413 jeanp413 self-requested a review February 17, 2023 19:23
@jeanp413 jeanp413 marked this pull request as draft February 17, 2023 19:23
@jeanp413 jeanp413 force-pushed the gt/update-prebuild-and-incremental-prebuild-emojis branch from fb9a339 to f56e6de Compare February 20, 2023 04:02
@roboquat roboquat added size/XS and removed size/S labels Feb 20, 2023
@jeanp413
Copy link
Member

jeanp413 commented Feb 20, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft with-preview with-large-vm

👎 unknown command: with-preview
Use /werft help to list the available commands

@jeanp413
Copy link
Member

jeanp413 commented Feb 20, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview with-large-vm

👍 started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.24
(with .werft/ from main)

@jeanp413 jeanp413 force-pushed the gt/update-prebuild-and-incremental-prebuild-emojis branch from f56e6de to 22ec223 Compare February 20, 2023 04:57
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-prebuild-and-incremental-prebuild-e.26 because the annotations in the pull request description changed
(with .werft/ from main)

@jeanp413 jeanp413 force-pushed the gt/update-prebuild-and-incremental-prebuild-emojis branch from 22ec223 to af4b0d0 Compare February 20, 2023 05:11
@roboquat roboquat added size/S and removed size/XS labels Feb 20, 2023
@socket-security
Copy link

socket-security bot commented Feb 20, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@jeanp413 jeanp413 force-pushed the gt/update-prebuild-and-incremental-prebuild-emojis branch from af4b0d0 to 03835f0 Compare February 20, 2023 14:08
@jeanp413
Copy link
Member

jeanp413 commented Feb 20, 2023 •
edited
Loading

@gtsiolis there's two issues here:

  • a terminal issue in general and how it handles unicode emojis (it's a hit and miss depending on the emoji), you can repro in your local native terminal too, workaround is to add 2 spaces after the ⏱️ emoji
  • even with the 2 spaces workaround, the terminal still renders the 🍊 incorrectly the first time but if you manually echo again in an attached terminal in vscode it renders fine, 🤔

@jeanp413 jeanp413 force-pushed the gt/update-prebuild-and-incremental-prebuild-emojis branch from 03835f0 to ed6e06b Compare February 20, 2023 15:15
@roboquat roboquat added size/M and removed size/S labels Feb 20, 2023
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 20, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Ah, I see. Thanks for taking the time to debug this, @jeanp413! 🙇

Noticed you made some changes in the latest push[1][2]. Is this something that could fix this? If not, what options do we have here? We could also use a different emoji set or characters.

@jeanp413
Copy link
Member

jeanp413 commented Feb 20, 2023 •
edited
Loading

Noticed you made some changes in the latest push[https://github.com//pull/16110#event-8562770707][2]. Is this something that could fix this?

I was doing some tests but didn't help

If not, what options do we have here? We could also use a different emoji set or characters.

yeah we could try that

@stale
Copy link

stale bot commented Mar 12, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 12, 2023
@stale stale bot closed this Mar 18, 2023
@gtsiolis gtsiolis mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanp413 jeanp413 Awaiting requested review from jeanp413

Assignees
No one assigned
Labels
do-not-merge/hold do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon release-note size/M team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent spacing in prebuild terminal message
3 participants
@gtsiolis @jeanp413 @roboquat