Skip to content

[vscode] allow user custom workspace timeout #16220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Feb 6, 2023

Description

[vscode] allow user custom workspace timeout

Review should happen in gitpod-io/gitpod-code#2, this PR only update gitpod-web extension

image

image

image

Related Issue(s)

Fixes #16157

How to test

Release Notes

Allow user custom workspace timeout in vscode.

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
  • /werft publish-to-npm

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-payment
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-iqqbot-update-the-vs-code-timeout-16157.2 because the annotations in the pull request description changed
(with .werft/ from main)

@iQQBot iQQBot force-pushed the iqqbot/update-the-vs-code-timeout-16157 branch from 1b8f7a1 to 36959b4 Compare February 6, 2023 07:18
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-iqqbot-update-the-vs-code-timeout-16157.4 because the annotations in the pull request description changed
(with .werft/ from main)

@iQQBot iQQBot force-pushed the iqqbot/update-the-vs-code-timeout-16157 branch from 36959b4 to 9d6592a Compare February 7, 2023 17:32
@iQQBot iQQBot marked this pull request as ready for review February 8, 2023 06:54
@iQQBot iQQBot requested a review from a team February 8, 2023 06:54
@akosyakov
Copy link
Member

akosyakov commented Feb 8, 2023

@iQQBot I wonder could we show somehow current timeout in the input?

cc @gtsiolis @loujaybee for UX review

@akosyakov
Copy link
Member

And I think we should be cleaner what timeout it is, i.e. idle or inactivity timeout.

@gtsiolis gtsiolis requested a review from a team February 8, 2023 12:46
@loujaybee
Copy link
Member

@akosyakov - I think we should be cleaner what timeout it is, i.e. idle or inactivity timeout.

Agree, can we use "Inactivity Timeout" as the language? That's what we use on the docs workspace lifecycle page.

See also related docs issue:

@loujaybee
Copy link
Member

loujaybee commented Feb 9, 2023

Question: Does this allow longer than 24h to be set? 🤔

@filiptronicek
Copy link
Member

filiptronicek commented Feb 10, 2023

/werft run

👍 started the job as gitpod-build-iqqbot-update-the-vs-code-timeout-16157.6
(with .werft/ from main)

@iQQBot iQQBot force-pushed the iqqbot/update-the-vs-code-timeout-16157 branch from 9d6592a to bcc58a8 Compare February 10, 2023 15:03
@iQQBot iQQBot force-pushed the iqqbot/update-the-vs-code-timeout-16157 branch from bcc58a8 to 9bd9787 Compare February 10, 2023 15:51
@roboquat roboquat merged commit 4b07cc4 into main Feb 10, 2023
@roboquat roboquat deleted the iqqbot/update-the-vs-code-timeout-16157 branch February 10, 2023 15:58
@roboquat roboquat added the deployed: IDE IDE change is running in production label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the VS Code timeout extend behaviour
5 participants