Hide the latest ide alert warning on workspace timeout

[Devansu-Yadav]

Description

• Removes the latest ide alert warning on the workspace timeout page and only shows it during workspace (re)start.

Related Issue(s)

Relates #11035

How to test

• Open workspace in preview env with a latest editor https://hide-editor-alert.preview.gitpod-dev.com/workspaces
• Alert should show during starting workspace
• Stop to see if the latest ide alert does not show up
• Open again with a stable editor
• Alert should not show during starting workspace
• Stop should have no alert

Release Notes

Removes the latest ide alert warning on the workspace timeout page

Documentation

Build Options:

• /werft with-github-actions
  Experimental feature to run the build with GitHub Actions (and not in Werft).
• /werft with-werft
• leeway-no-cache
  leeway-target=components:all
• /werft no-test
  Run Leeway with --dont-test

Publish Options

• /werft publish-to-npm
• /werft publish-to-jb-marketplace

Installer Options

• with-ee-license
• with-slow-database
• with-dedicated-emulation
• with-ws-manager-mk2
• workspace-feature-flags
  Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-gce-vm
  If enabled this will create the environment on GCE infra
• /werft with-integration-tests=all
  Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

[werft-gitpod-dev-com]

annotations in the pull request changed, but user is not allowed to start a job

[werft-gitpod-dev-com]

started the job as gitpod-build-hide-editor-alert.0 because the annotations in the pull request description changed
(with .werft/ from main)

[gtsiolis]

/werft run with-preview=true

👍 started the job as gitpod-build-hide-editor-alert-fork.0
(with .werft/ from main)

[Devansu-Yadav]

/werft run with-preview=true

👍 started the job as gitpod-build-hide-editor-alert-fork.0 (with .werft/ from main)

@gtsiolis Do the changes in this PR hide the warning on the workspace timeout page? I can't seem to test this change as I don't have permission to create a workspace in the preview environment 😅

[gtsiolis]

/werft run with-preview=true

👍 started the job as gitpod-build-hide-editor-alert-fork.1
(with .werft/ from main)

[gtsiolis]

/werft run with-preview=true

👍 started the job as gitpod-build-hide-editor-alert-fork.2
(with .werft/ from main)

[gtsiolis]

UX LGTM, @Devansu-Yadav! 🌮 🌮

I could verify the warning is no longer present after the workspace timed out. 🏁

Approving to unblock merging but holding to pass this to @gitpod-io/engineering-webapp to pull the trigger in case there's anything that looks unnecessary and needs a revert or a different approach. 🏓

Looping in also @mustard-mh who recently edited this file to add this warning in the first place.

/hold

[Devansu-Yadav]

Approving to unblock merging but holding to pass this to @gitpod-io/engineering-webapp to pull the trigger in case there's anything that looks unnecessary and needs a revert or a different approach. 🏓

Looping in also @mustard-mh who recently edited this file to add this warning in the first place.

/hold

@gtsiolis Any updates on whether any changes are required in this PR or not?

[mustard-mh]

/werft run

👍 started the job as gitpod-build-hide-editor-alert-fork.3
(with .werft/ from main)

[werft-gitpod-dev-com]

started the job as gitpod-build-hide-editor-alert.1 because the annotations in the pull request description changed
(with .werft/ from main)

[mustard-mh]

Any updates on whether any changes are required in this PR or not?

Hey @Devansu-Yadav 👋 Thanks for your contributions!! 🧡

I prefer to call the variable isTimedOut and check with showLatestIdeWarning = !isTimedOut && useLatest

We will need review from @gitpod-io/engineering-webapp as codeowner

pinged in our development pipeline to resolve the preview env problem 🙏

[Devansu-Yadav]

I prefer to call the variable isTimedOut and check with showLatestIdeWarning = !isTimedOut && useLatest

@mustard-mh That seems much better! Should I go ahead and make this change?

We will need review from @gitpod-io/engineering-webapp as codeowner

Sure, I'll wait 😄

[mustard-mh]

Should I go ahead and make this change?

@Devansu-Yadav Sure, let's go with it 🚀

After your changes, I will do the final test in preview env, and then unhold this PR since you get approve from WebApp 👍

[gtsiolis]

/werft run with-preview

👍 started the job as gitpod-build-hide-editor-alert-fork.4
(with .werft/ from main)

[mustard-mh]

I tested it in preview env, and it worked with Timed Out

But when with phases like Stopped Stopping, we still got this warning. I will unhold this PR and change (changed) the related issue's description for them. @Devansu-Yadav Thank you for your contribution! 🧡

Stopped	Timed Out

[mustard-mh]

/unhold

[gtsiolis]

@mustard-mh This can't be merged because the build fails after the new switch to GH Actions, right?

See relevant discussion (internal). Cc @vulkoingim

[Devansu-Yadav]

But when with phases like Stopped Stopping, we still got this warning. I will updated unhold this PR and change the related issue's description for them. @Devansu-Yadav Thank you for your contribution! 🧡

Ohh okay, but I guess the scope of this issue mostly focussed on the UX where we don't want to show this warning on the Timed Out phase, isn't it @gtsiolis? 😅

If needed I could probably address this either in this same PR or maybe open up a separate PR for them..

[mustard-mh]

But when with phases like Stopped Stopping, we still got this warning. I will updated unhold this PR and change the related issue's description for them. @Devansu-Yadav Thank you for your contribution! 🧡

Ohh okay, but I guess the scope of this issue mostly focussed on the UX where we don't want to show this warning on the Timed Out phase, isn't it @gtsiolis? 😅

If needed I could probably address this either in this same PR or maybe open up a separate PR for them..

@Devansu-Yadav Yep, we can do it separately 👍 , updated the issue description you can pick it up if you want and get time 🙏

[Devansu-Yadav]

@Devansu-Yadav Yep, we can do it separately 👍 , updated the issue description you can pick it up if you want and get time 🙏

Great, I'll raise a PR for both these phases once this PR is merged 😄

[werft-gitpod-dev-com]

started the job as gitpod-build-hide-editor-alert.4 because the annotations in the pull request description changed
(with .werft/ from main)

[gtsiolis]

Build seems successful. Removing hold.

Thanks @mustard-mh & @iQQBot for triggering the builds[1][2].

/unhold

[iQQBot]

It's looks not success, because

github action build is required, but this action will fail maybe because we don't send secret to fork, screenshot from https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/

[iQQBot]

/hold

cc @mads-hartmann

[gtsiolis]

For visibility, I'm trying re-triggering the job with what @vulkoingim suggested[1] (internal) which helped merge another community contribution in #16417.

https://werft.gitpod-dev.com/job/gitpod-build-hide-editor-alert.6

[vulkoingim]

Apologies for the back-and-forth on this issue @Devansu-Yadav . Currently we're doing changes around our build/CI systems and there are still some details we haven't smoothed out. I'll get back to you next week, once we have resolved the outstanding issues and will push this through.

[Devansu-Yadav]

Currently we're doing changes around our build/CI systems and there are still some details we haven't smoothed out. I'll get back to you next week, once we have resolved the outstanding issues and will push this through.

@vulkoingim Any updates on this? 😅

[vulkoingim]

Currently we're doing changes around our build/CI systems and there are still some details we haven't smoothed out. I'll get back to you next week, once we have resolved the outstanding issues and will push this through.

@vulkoingim Any updates on this? 😅

Apologies for the delay - got it merged just now. Thank you for your contribution! :)