-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Hide the latest ide alert warning on workspace timeout #16551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
annotations in the pull request changed, but user is not allowed to start a job |
started the job as gitpod-build-hide-editor-alert.0 because the annotations in the pull request description changed |
/werft run with-preview=true 👍 started the job as gitpod-build-hide-editor-alert-fork.0 |
9859e89
to
3618253
Compare
@gtsiolis Do the changes in this PR hide the warning on the workspace timeout page? I can't seem to test this change as I don't have permission to create a workspace in the preview environment 😅 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/werft run with-preview=true 👍 started the job as gitpod-build-hide-editor-alert-fork.1 |
3618253
to
354dc2b
Compare
/werft run with-preview=true 👍 started the job as gitpod-build-hide-editor-alert-fork.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX LGTM, @Devansu-Yadav! 🌮 🌮
I could verify the warning is no longer present after the workspace timed out. 🏁
Approving to unblock merging but holding to pass this to @gitpod-io/engineering-webapp to pull the trigger in case there's anything that looks unnecessary and needs a revert or a different approach. 🏓
Looping in also @mustard-mh who recently edited this file to add this warning in the first place.
/hold
@gtsiolis Any updates on whether any changes are required in this PR or not? |
/werft run 👍 started the job as gitpod-build-hide-editor-alert-fork.3 |
started the job as gitpod-build-hide-editor-alert.1 because the annotations in the pull request description changed |
Hey @Devansu-Yadav 👋 Thanks for your contributions!! 🧡 I prefer to call the variable We will need review from @gitpod-io/engineering-webapp as codeowner pinged in our development pipeline to resolve the preview env problem 🙏 |
@mustard-mh That seems much better! Should I go ahead and make this change?
Sure, I'll wait 😄 |
@Devansu-Yadav Sure, let's go with it 🚀 After your changes, I will do the final test in preview env, and then unhold this PR since you get |
354dc2b
to
edbc477
Compare
/werft run with-preview 👍 started the job as gitpod-build-hide-editor-alert-fork.4 |
I tested it in preview env, and it worked with But when with phases like
|
/unhold |
@mustard-mh This can't be merged because the build fails after the new switch to GH Actions, right? See relevant discussion (internal). Cc @vulkoingim |
Ohh okay, but I guess the scope of this issue mostly focussed on the UX where we don't want to show this warning on the If needed I could probably address this either in this same PR or maybe open up a separate PR for them.. |
@Devansu-Yadav Yep, we can do it separately 👍 , updated the issue description you can pick it up if you want and get time 🙏 |
Great, I'll raise a PR for both these phases once this PR is merged 😄 |
started the job as gitpod-build-hide-editor-alert.4 because the annotations in the pull request description changed |
Build seems successful. Removing hold. Thanks @mustard-mh & @iQQBot for triggering the builds[1][2]. /unhold |
It's looks not success, because github action build is required, but this action will fail maybe because we don't send secret to fork, screenshot from https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/ |
/hold |
For visibility, I'm trying re-triggering the job with what @vulkoingim suggested[1] (internal) which helped merge another community contribution in #16417.
|
Apologies for the back-and-forth on this issue @Devansu-Yadav . Currently we're doing changes around our build/CI systems and there are still some details we haven't smoothed out. I'll get back to you next week, once we have resolved the outstanding issues and will push this through. |
@vulkoingim Any updates on this? 😅 |
Apologies for the delay - got it merged just now. Thank you for your contribution! :) |
Description
Related Issue(s)
Relates #11035
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh