Skip to content

[git] implement scope elevation in server #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2021
Merged

[git] implement scope elevation in server #3565

merged 2 commits into from
Mar 27, 2021

Conversation

JanKoehnlein
Copy link
Contributor

No description provided.

@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Mar 24, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jankoehnlein-code-notify-a-user-2810.19

@JanKoehnlein JanKoehnlein force-pushed the jankoehnlein/code-notify-a-user-2810 branch 8 times, most recently from 488d57c to 276cde7 Compare March 24, 2021 13:41
@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Mar 24, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jankoehnlein-code-notify-a-user-2810.30

@JanKoehnlein JanKoehnlein marked this pull request as ready for review March 24, 2021 14:05
@JanKoehnlein JanKoehnlein force-pushed the jankoehnlein/code-notify-a-user-2810 branch from 276cde7 to ba382aa Compare March 24, 2021 14:10
@JanKoehnlein
Copy link
Contributor Author

So finally this is ready for review!

Steps to test

  • In the dev-stagng env, start a workspace on a public repo with default permissions
  • try git push from terminal or from the source control view => You get a dialog pointing to the access control page
  • give access to public repos and try again. Should work now without any messages
  • change the repos's visibility to private and start again => A slightly different dialog appears
  • give access to private repos and try again. Should work now without any messages

So far I've only tested with GitHub.

@JanKoehnlein JanKoehnlein force-pushed the jankoehnlein/code-notify-a-user-2810 branch from ba382aa to ff65870 Compare March 24, 2021 15:34
@JanKoehnlein
Copy link
Contributor Author

GitLab works as well. Cannot test Bitbucket because it's not yet hooked up to the new dashboard.

@svenefftinge
Copy link
Member

svenefftinge commented Mar 24, 2021 •
edited
Loading

Cool! Would be good to use the same style as the github app. I mean to present it

  • as information (not error)
  • have the text expanded
  • use a button (command) to open the access control page.

Screenshot 2021-03-24 at 17 29 34

Works super well otherwise and will be a huge help for users! 🎉

csweichel
csweichel reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks for making your way across all the layers involved in this change.

akosyakov
akosyakov reviewed Mar 25, 2021
View reviewed changes
@JanKoehnlein
Copy link
Contributor Author

Thanks a lot for the reviews.

@svenefftinge I've changed the severity of the dialog to INFO. The dialog is expanded when it has buttons. We currently don't have these buttons but just a link because our notification protocol currently assumes that the notifier performs on the actions, and we don't have a protocol to open a new tab in the client yet. We should maybe spec out the protocol in a follow up issue.

@JanKoehnlein JanKoehnlein force-pushed the jankoehnlein/code-notify-a-user-2810 branch from 5ec0e92 to b56c07b Compare March 26, 2021 10:17
@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Mar 26, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jankoehnlein-code-notify-a-user-2810.35

@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Mar 26, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jankoehnlein-code-notify-a-user-2810.36

@JanKoehnlein JanKoehnlein force-pushed the jankoehnlein/code-notify-a-user-2810 branch from b56c07b to 7e82d52 Compare March 26, 2021 15:01
@JanKoehnlein
Copy link
Contributor Author

So I've addressed all feedback, rebased and squashed. Can I merge?

akosyakov
akosyakov approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosyakov akosyakov merged commit 49d3aa8 into main Mar 27, 2021
@akosyakov akosyakov deleted the jankoehnlein/code-notify-a-user-2810 branch March 27, 2021 08:47
@akosyakov
Copy link
Member

@JanKoehnlein I merged it to clean up common-go in #3569

@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Mar 27, 2021 via email •
edited by werft-gitpod-dev-com bot
Loading

@JanKoehnlein JanKoehnlein mentioned this pull request Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel csweichel left review comments

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JanKoehnlein @svenefftinge @akosyakov @csweichel