Skip to content

[cli] allow to open external URLs in a new tab #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

[cli] allow to open external URLs in a new tab #3646

merged 1 commit into from
Mar 31, 2021

Conversation

JanKoehnlein
Copy link
Contributor

A follow up on #3565.
Allows gp preview to open pages in new tabs

@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Mar 29, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jk-notification-protocol-extension.7

@JanKoehnlein JanKoehnlein force-pushed the jk/notification-protocol-extension branch from 5e57a96 to a924def Compare March 29, 2021 14:59
akosyakov
akosyakov reviewed Mar 29, 2021
View reviewed changes
@JanKoehnlein JanKoehnlein force-pushed the jk/notification-protocol-extension branch 8 times, most recently from f8dc2e3 to 014884d Compare March 30, 2021 07:42
@JanKoehnlein JanKoehnlein force-pushed the jk/notification-protocol-extension branch from 014884d to 9f12e09 Compare March 30, 2021 07:55
@JanKoehnlein JanKoehnlein marked this pull request as ready for review March 30, 2021 07:55
@JanKoehnlein
Copy link
Contributor Author

When testing: not that the info dialog currently comes very late sometimes minutes (!) after the notification. I think we're waiting for OpenVSX before we actually start the Gitpod extension and thus register for notifications. Could be related to #3643

@JanKoehnlein
Copy link
Contributor Author

JanKoehnlein commented Mar 30, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jk-notification-protocol-extension.18

@JanKoehnlein JanKoehnlein requested a review from csweichel March 30, 2021 11:45
@akosyakov
Copy link
Member

akosyakov commented Mar 30, 2021 •
edited
Loading

When testing: not that the info dialog currently comes very late sometimes minutes (!) after the notification. I think we're waiting for OpenVSX before we actually start the Gitpod extension and thus register for notifications. Could be related to #3643

We are waiting for the initial extensions to be installed before allowing starting any extensions :( I tried to remove it but then you start without extensions and sometimes have to reload the page to apply them. Although I don't think it applies to the built-in extensions 🤔

akosyakov
akosyakov approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked well for me

@JanKoehnlein JanKoehnlein merged commit 4279d3a into main Mar 31, 2021
@JanKoehnlein JanKoehnlein deleted the jk/notification-protocol-extension branch March 31, 2021 10:01
pavan-tri pushed a commit to trilogy-group/gitpod that referenced this pull request Apr 28, 2021
@JanKoehnlein
[cli] allow to open external URLs in a new tab (gitpod-io#3646)
fbafa4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

@csweichel csweichel Awaiting requested review from csweichel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanKoehnlein @akosyakov