Skip to content

Call /ide/bin/code explicitely instead of relying on PATH #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2021
Merged

Call /ide/bin/code explicitely instead of relying on PATH #3846

merged 1 commit into from
Apr 8, 2021

Conversation

pattacini
Copy link
Contributor

@pattacini pattacini commented Apr 8, 2021 •
edited
Loading

This PR implements request #3844 to force the use of /ide/bin/code explicitly and thus allow a custom installation of code to coexist with the Gitpod CLI gracefully.

@pattacini pattacini mentioned this pull request Apr 8, 2021
Closed
@akosyakov
Copy link
Member

akosyakov commented Apr 8, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-patch-1-fork.1

akosyakov
akosyakov approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gp works nicely with it, even if code is overloaded

@akosyakov akosyakov merged commit 9b37719 into gitpod-io:main Apr 8, 2021
This was referenced Apr 8, 2021
Closed
Closed
@pattacini
Copy link
Contributor Author

pattacini commented Apr 8, 2021 •
edited
Loading

Thanks heaps for this @akosyakov 🎉
Am I already able to test this with my workspace or should I need to wait for some deployment to be done in production first?

@pattacini
Copy link
Contributor Author

pattacini commented Apr 8, 2021 •
edited by werft-gitpod-dev-com bot
Loading

I missed this info #3844 (comment).
Tomorrow then, great 👍🏻

@jankeromnes jankeromnes mentioned this pull request May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pattacini @akosyakov @gtsiolis