-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[baseserver] Dedicated debug server #9742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12e7175
to
2ea6576
Compare
csweichel
reviewed
May 5, 2022
19aad85
to
454e8c1
Compare
csweichel
reviewed
May 9, 2022
454e8c1
to
6e3c56f
Compare
/werft run 👍 started the job as gitpod-build-mp-baseserver-debug.9 |
bc378ed
to
b915f6c
Compare
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-baseserver-debug.13 |
b915f6c
to
71b2b02
Compare
andrew-farries
suggested changes
May 12, 2022
71b2b02
to
9a6e955
Compare
andrew-farries
approved these changes
May 12, 2022
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-baseserver-debug.17 |
73766a0
to
c4b43f3
Compare
c4b43f3
to
d8a4997
Compare
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: webapp
Meta team change is running in production
deployed
Change is completely running in production
release-note-none
size/XL
team: webapp
Issue belongs to the WebApp team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a dedicated debug server to baseserver. This splits up the existing HTTP server into 2.
The debug server is always started, but the HTTP server (intended for serving non debug endpoints - ie actual traffic) is only started when configured. This aligns it more closely with existing components we run.
Related Issue(s)
Fixes #
How to test
Unit tests
Release Notes
Documentation
NONE
/hold