Skip to content

[baseserver] Dedicated debug server #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2022
Merged

[baseserver] Dedicated debug server #9742

merged 2 commits into from
May 13, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 3, 2022

Description

Adds a dedicated debug server to baseserver. This splits up the existing HTTP server into 2.

The debug server is always started, but the HTTP server (intended for serving non debug endpoints - ie actual traffic) is only started when configured. This aligns it more closely with existing components we run.

Related Issue(s)

Fixes #

How to test

Unit tests

Release Notes

NONE

Documentation

NONE

/hold

@easyCZ easyCZ force-pushed the mp/baseserver-debug branch 3 times, most recently from 19aad85 to 454e8c1 Compare May 6, 2022 07:33
@easyCZ easyCZ force-pushed the mp/baseserver-debug branch from 454e8c1 to 6e3c56f Compare May 9, 2022 13:09
@easyCZ
Copy link
Member Author

easyCZ commented May 9, 2022

/werft run

👍 started the job as gitpod-build-mp-baseserver-debug.9
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/baseserver-debug branch 3 times, most recently from bc378ed to b915f6c Compare May 10, 2022 14:58
@easyCZ
Copy link
Member Author

easyCZ commented May 12, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-baseserver-debug.13
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/baseserver-debug branch from b915f6c to 71b2b02 Compare May 12, 2022 09:08
@easyCZ easyCZ force-pushed the mp/baseserver-debug branch from 71b2b02 to 9a6e955 Compare May 12, 2022 13:07
@easyCZ easyCZ requested a review from andrew-farries May 12, 2022 14:19
@easyCZ
Copy link
Member Author

easyCZ commented May 12, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-baseserver-debug.17
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/baseserver-debug branch from 73766a0 to c4b43f3 Compare May 13, 2022 07:45
@easyCZ easyCZ force-pushed the mp/baseserver-debug branch from c4b43f3 to d8a4997 Compare May 13, 2022 08:09
@easyCZ
Copy link
Member Author

easyCZ commented May 13, 2022

/unhold

@roboquat roboquat merged commit b09cda8 into main May 13, 2022
@roboquat roboquat deleted the mp/baseserver-debug branch May 13, 2022 09:02
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants