Skip to content

[installer] Refactor generation of templates configmap #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 9, 2022

Description

With the introduction of workspace classes and the default gitpod.io/internal/xl we need to change the path to not contain "directories".

"templates": {
  "defaultPath": "/workspace-templates/gitpod.io-internal-xl-default.yaml",
  "regularPath": "/workspace-templates/gitpod.io-internal-xl-regular.yaml",
  "prebuildPath": "/workspace-templates/gitpod.io-internal-xl-prebuild.yaml",
  "imagebuildPath": "/workspace-templates/gitpod.io-internal-xl-imagebuild.yaml"
},

Release Notes

[installer] Refactor generation of templates configmap #9868

@aledbf aledbf marked this pull request as ready for review May 9, 2022 21:43
@aledbf aledbf requested a review from a team May 9, 2022 21:43
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 9, 2022
@aledbf
Copy link
Member Author

aledbf commented May 9, 2022

/hold

@csweichel
Copy link
Contributor

We could still use directories - just sanitise the class name as done here in this PR

@aledbf
Copy link
Member Author

aledbf commented May 10, 2022

We could still use directories - just sanitise the class name as done here in this PR

that is not a valid name in a configmap (fails with a similar error to label values)

@csweichel
Copy link
Contributor

superseeded by #9895?

@aledbf
Copy link
Member Author

aledbf commented May 10, 2022

superseeded by #9895?

Yes. Closing.

@aledbf aledbf closed this May 10, 2022
@aledbf aledbf deleted the aledbf/ins branch July 31, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants