Skip to content

[ws-manager] Improve workspace class name validation #9895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2022
Merged

Conversation

csweichel
Copy link
Contributor

Description

This PR improves the validation of workspace class names.

How to test

See unit tests

Release Notes

NONE

@csweichel csweichel requested a review from a team May 10, 2022 10:19
@csweichel csweichel requested review from aledbf and sagor999 as code owners May 10, 2022 10:19
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 10, 2022
@csweichel csweichel force-pushed the cw/better-classes branch from b5962ca to 988d470 Compare May 10, 2022 10:30
@csweichel csweichel requested a review from a team May 10, 2022 10:38
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 10, 2022
@csweichel csweichel force-pushed the cw/better-classes branch from 33cfc29 to a2d09f9 Compare May 10, 2022 10:39
@roboquat roboquat merged commit 754e756 into main May 10, 2022
@roboquat roboquat deleted the cw/better-classes branch May 10, 2022 11:13
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants