Full refactor of this repository #204
Conversation
I believe that this makes it much more efficient to maintain while providing more features DO_NOT_MERGE: Dockerimages has to be tested to ensure that they fit abstract, since i don't the permission i can't ensure that it does.
|
NOTICE: The other "cores" does not have the abstract implemented yet, requesting more info for the abstract (See in-code docummentation in case i forgot something) and method to test the images to ensure that it works as expected. |
.circleci/build_image.sh
Outdated
| @@ -1,4 +1,7 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # FIXME(Kreyren): Oh gawd who wrote this, Abstract required for proper implementation | |||
There was a problem hiding this comment.
Also i need abstract for the CircleCI to fix code quality and hopefully improve the runtime.
|
This should also permanently resolve issues alike #204 and other security and maintainance issues associated with ubuntu. |
|
Maitainers: No need to review i figured out reliable way to test this commit will ping you when it's finished~ |
|
NOTICE: Shellcheck 0.5.0 is not usable, see false trigger:
Code: case "$DISTRO" in
debian)
case "$expectedShell" in
bash) apt install -y bash-completion || die 1 "Unable to install bash-completion" ;;
sh|dash) true ;; # nothing else to do here
powershell) apt install -y powershell || die 1 "Unable to install powershell" ;;
*) die 255 "Unexpected shell in variable expectedShell with value '$expectedShell' has been provided to shellConfig script"
esac
;;
*) die 255 "Unexpected distribution '$DISTRO' has been parsed in shellConfig script"
esac |
|
Hi @Kreyren, please try to avoid sending as many commits to this Pull Request. Many of us receive a notification for every commit, and it also triggers a new full CircleCI workflow, which is quite resource-intensive. |
I though that you won't be getting notifications for draft merge requests? Noted, closing will reopen once finished. |
|
Development moved on Kreyren#1 |
Development moved on Kreyren#1
DO_NOT_MERGE: Work in progress..
MAINTAINERS
Review once all checks are completed
Required assistance
CONTRIBUTORS
appending the last layer will be handled explicitely by me since this is a close-source code set for security.
Checklist (later used as changelog)
gitpod/<core>dockerimages that set the mandatory minimums for specified dockerimageshellproperty in theirgitpod.ymlfiles to use following shells:packageproperty ingitpod.ymlto install various packages without the need to use dockerfileReferences
Attempts-to-resolve: Running gitpod in CLI/TUI? gitpod#1258
Attempts-to-resolve: Gitpod is too noisy for benchmarking gitpod#1217
Attempts-to-resolve: Can i test github actions on gitpod? gitpod#1211
Attempts-to-resolve: Unable to clone repos using ssh gitpod#1191
Attempts-to-resolve: vlang: Linting of vlang is not supported on gitpod gitpod#1144
Attempts-to-resolve: vlang: Gitpod is unable to compile vlang gitpod#1143
Attempts-to-resolve: Temporary users without github/gitlab account? gitpod#1141
Attempts-to-resolve: Cargo login (rustlang): Method to store token for crates.io gitpod#1095
Attempts-to-resolve: VM Support gitpod#1265
Attempts-to-resolve: Vagrant support gitpod#1251
Attempts-to-resolve: Cargo login (rustlang): Method to store token for crates.io gitpod#1095
Attempts-to-resolve: Lua support for Gitpod gitpod#1041
Attempts-to-resolve: Nimlang support gitpod#845
Attempts-to-resolve: Maven gitpod#828
Attempts-to-resolve: Julia language support gitpod#812
Attempts-to-resolve: Swift language support gitpod#805
Attempts-to-resolve: jsonnet support gitpod#761
Attempts-to-resolve: F# support gitpod#632
Attempts-to-resolve: Elm support gitpod#474
Attempts-to-resolve: RDF/turtle support gitpod#448
Attempts-to-resolve: Free Pascal support gitpod#283
Attempts-to-resolve: Haskell Support gitpod#240
Attempts-to-resolve: Arduino Support gitpod#116
Attempts-to-resolve: Sass/Less support gitpod#92
Attempts-to-resolve: Support LaTeX gitpod#84
Attempts-to-resolve: Support Elixir language gitpod#30
fixes: Error while adding gitpod layer gitpod#813
fixes: Unwanted PS1 manipulation gitpod#1252
fixes: Emmet Support gitpod#22
fixes: C# Support gitpod#17
may-resolve: Feature Request: Support Kubernetes gitpod#1337
may-resolve: Compatibility for luna-lang? gitpod#1295
may-resolve: Move config to
.gitpodfolder gitpod#729may-resolve: Gitea support gitpod#80
may-resolve: Docker support gitpod#52
is-expected-to-help-with: Gitpod for hardware design? gitpod#1046
is-expected-to-help-with: https://github.com/gitpod-io/gitpod/issues?q=is%3Aissue+is%3Aopen+label%3Aoperations
This follows up on my contribution in gitpod-layer
Notes
Images can be tested using