-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Closed
Labels
Milestone
Description
Description
I have a workflow file with three different jobs. The workflow is triggered by push
and issue_comment
events, and an if statement in the job definition decides which of the jobs gets executed by the github.event_name
variable.
In the actions list (/actions?workflow=&state=closed
) the action run is being displayed as successful.
When opening the log view, the skipped job is being displayed correctly, but the steps are being displayed as failed.
In the code view, the action is being displayed as failed, and in the tooltip, the skipped job is being displayed as failed.
Gitea Version
1.19.0
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Using the official docker image
Database
SQLite
Metadata
Metadata
Assignees
Labels
Type
Projects
Relationships
Development
Select code repository
Activity
a1012112796 commentedon Mar 21, 2023
that's because there are only five optional commit status now: "pending", "success", "error", "failure", and "warning"
yardenshoham commentedon Mar 21, 2023
I think GitHub keeps it on "pending" https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks
We could also add a new status? "skipped"
a1012112796 commentedon Mar 22, 2023
Hmm, I think whether
skipped
meansfailed
should be optional for each repo.denyskon commentedon Mar 22, 2023
GitHub also seems to have
neutral
for that, at least that's what I have seen a few times.....Refactor commit status for Actions jobs (#23786)
Backport go-gitea#23786 to v1.19
Refactor commit status for Actions jobs (#23786) (#24060)