Skip to content

[actions] Skipped jobs are displayed as failed #23599

@denyskon

Description

@denyskon
Member

Description

I have a workflow file with three different jobs. The workflow is triggered by push and issue_comment events, and an if statement in the job definition decides which of the jobs gets executed by the github.event_name variable.

In the actions list (/actions?workflow=&state=closed) the action run is being displayed as successful.

grafik

When opening the log view, the skipped job is being displayed correctly, but the steps are being displayed as failed.

grafik

In the code view, the action is being displayed as failed, and in the tooltip, the skipped job is being displayed as failed.

grafik

Gitea Version

1.19.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Using the official docker image

Database

SQLite

Activity

a1012112796

a1012112796 commented on Mar 21, 2023

@a1012112796
Member

that's because there are only five optional commit status now: "pending", "success", "error", "failure", and "warning"

added this to the 1.19.1 milestone on Mar 21, 2023
a1012112796

a1012112796 commented on Mar 22, 2023

@a1012112796
Member

Hmm, I think whether skipped means failed should be optional for each repo.

denyskon

denyskon commented on Mar 22, 2023

@denyskon
MemberAuthor

GitHub also seems to have neutral for that, at least that's what I have seen a few times.....

added a commit that references this issue on Mar 29, 2023
3e8db31
added a commit that references this issue on Apr 11, 2023
43fbda4
added a commit that references this issue on Apr 12, 2023
29724f3
locked and limited conversation to collaborators on May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @lunny@yardenshoham@a1012112796@denyskon

      Issue actions

        [actions] Skipped jobs are displayed as failed · Issue #23599 · go-gitea/gitea