Closed
Description
Description
If an action was skipped, it gets a green tick on the Closed
page
But on the code page, it gets a cross
Maybe a red bent arrow like a missed phone call will be better, see below?
Gitea Version
1.19.0
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Using docker
Database
MySQL
Activity
silverwind commentedon Apr 9, 2023
Does octicons have something suitable?
bilogic commentedon Apr 9, 2023
@silverwind
They use this to represent skip https://primer.github.io/octicons/skip-24
But I think the ones I googled convey meaning better.. I'm in a dilemma myself over the bent arrow or over the empty box
Anyway, the issue is the inconsistent icon, if it is easier to just use https://primer.github.io/octicons/skip-24, then it would also solve the problem.
silverwind commentedon Apr 9, 2023
We use only 16px, so it'd be https://primer.github.io/octicons/skip-16
wolfogre commentedon Apr 10, 2023
Related toDuplicated with #23599.The point is that there is no
skipped
for commit status, and it has been treated assuccess
in #23786silverwind commentedon Apr 10, 2023
Shouldn't we not use
octicon-skip
?bilogic commentedon Apr 10, 2023
@wolfogre
Thanks, I understand gitea's approach of following github entirely, but also gave this some thought:
It's pretty confusing to:
Show the
commit status icon
+ commit message on the actions pageBut show
action status icon
+ commit message on the code pageSince the intention on code page is to show the last commit, it should stay the same regardless whether actions are enabled or not
Instead of prefixing the

action status icon
to the commit message, I feel it is better to append that icon to the commit message followed by the job name, which is consistent on theactions page
Based on my OP, that would be
where
X
is the icon, andlinux_tests
is the job name, which is what is shown when hovering over the code page'saction status icon
todayI can elaborate with more images if the above is not clear.
wolfogre commentedon Apr 10, 2023
I have no objection to using a better icon to replace

But I don't think it is the point.
wolfogre commentedon Apr 10, 2023
@bilogic Sorry I'm confused.
I think it's
action status icon
+ commit message on the actions page nowI think it's
commit status icon
+ commit message on the code page nowSorry, what do you mean by "should stay the same"? The commit status could be used even without Actions.
"prefixing the
action status icon
to the commit message", could you show me where?Update:
To be clear.
When those are commit status with commit status icons.
And those are actions status with actions status icons.
bilogic commentedon Apr 11, 2023
@wolfogre yes thanks, let me show you what i'm seeing here
This is
code
page when actions are disabled:hash
+commit message
(No icons)When
actions
are enabled and have ran,code
page inserts an icon (red):hash
+iconRed
+commit message
On
actions
page, we see a different icon (blue):iconBlue
+commit message
Clicking into the commit message, we see a 3rd different icon (green):
iconGreen
+job_name
so what I'm trying to ask here is:
Can we make all 3 icons the same, based on the
Completed job
?To put it in context of my OP (skipped job), it currently shows
iconGreen
+job_name
. Why not also makeiconBlue
andiconRed
show the same icon consistently?I also wondered, how many statuses does a
git commit
have? There are no icon/status whenactions
are disabled. And for me, it is either a committed or could not commit, and if it could not be committed, there are actually no records of it ingit
. So why do we havecommit icon/status
now? Could it actually be something else? Thus, my suggestion to place this icon elsewhere instead of prepending to thecommit message
Now, I must say, I'm very new to actions, I tried hard to see if I missed any scenarios, but could not come up with much.
Open to hearing if the current icons represents something I might have missed. Thank you!
wolfogre commentedon Apr 11, 2023
Thank you for your explanation, I think I understand now.
So I will make the second and third icons the same. But the first icons are for commit status which is a different thing.
As mentioned,
iconBlue
should show the same icon withiconGreen
, buticonRed
is for a different thing.Commit status:
pending
success
error
failure
warning
running
Actions status:
unknown
waiting
running
success
failure
cancelled
skipped
blocked
And how Gitea map them:
success
,skipped
success
failure
,cancelled
failure
waiting
,blocked
pending
running
running
So I would say they are different things.
The commit statuses are for binding CICD results to commits, and Gitea Actions is just one of the CICD tools; other tools, like DroneCI, could also send commit statuses. In other words, if you don't enable any CICD tools, there won't be any commit statuses.
You may have misunderstood, the commit status is not for whether the branch can be committed. It is mainly for "Branch Protection", like:
I don't understand, I mean, GitHub does it this way too.
bilogic commentedon Apr 11, 2023
@wolfogre ok thanks, I have little to no understanding of the above. But since it is a thing, I'm sure you guys know better than me.
Use same action status svg icons on actions list as on action page (#…