Skip to content

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jan 17, 2022

1.16.0 - 2022-01-18

@techknowlogick techknowlogick added this to the 1.16.0 milestone Jan 17, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #18309 (fca873d) into main (4a20ead) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18309      +/-   ##
==========================================
- Coverage   45.79%   45.78%   -0.01%     
==========================================
  Files         831      831              
  Lines       92222    92222              
==========================================
- Hits        42233    42227       -6     
- Misses      43230    43238       +8     
+ Partials     6759     6757       -2     
Impacted Files Coverage Δ
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
modules/queue/workerpool.go 49.61% <0.00%> (-1.15%) ⬇️
routers/api/v1/repo/pull.go 28.35% <0.00%> (-0.51%) ⬇️
modules/queue/queue_bytefifo.go 63.47% <0.00%> (+0.59%) ⬆️
modules/queue/queue_disk_channel.go 62.72% <0.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a20ead...fca873d. Read the comment docs.

Copy link
Member Author

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went over this on mobile so I can't do the "suggested" change thing, so just made a few comments about nits that I can go back later for

Signed-off-by: Andrew Thornton <[email protected]>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 18, 2022
@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 18, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2022
techknowlogick and others added 2 commits January 19, 2022 11:34
Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@6543 6543 merged commit 4a6bae5 into go-gitea:main Jan 19, 2022
@techknowlogick techknowlogick deleted the 1160rc1-changelog branch January 19, 2022 17:32
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV rendering for TSV files does not show rows with empty fields
6 participants