Skip to content

Optimize Overflow Menu #34183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 13, 2025
Merged

Optimize Overflow Menu #34183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f3fa4dd
Optimized the overflow-menu:
kerwin612 Apr 12, 2025
8bab94a
fix
kerwin612 Apr 12, 2025
be93e15
fix
kerwin612 Apr 12, 2025
8cf1467
fix
kerwin612 Apr 12, 2025
8315fb6
temp
wxiaoguang Apr 12, 2025
24bcb49
use addDelegatedEventListener
wxiaoguang Apr 12, 2025
dfc1391
fix overflow bug
wxiaoguang Apr 12, 2025
2cf17b1
fix wrong call order
wxiaoguang Apr 12, 2025
e870f29
Merge branch 'main' into feat/optimize-overflow-menu
wxiaoguang Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions web_src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,14 @@ overflow-menu .overflow-menu-button {
padding: 0;
}

overflow-menu .overflow-menu-button.active {
margin: 0 0 -2px;
border-bottom: 2px solid transparent;
background-color: transparent;
border-color: currentcolor;
font-weight: var(--font-weight-medium);
}

overflow-menu .overflow-menu-button:hover {
color: var(--color-text-dark);
}
Expand Down
2 changes: 1 addition & 1 deletion web_src/js/components/DashboardRepoList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ export default defineComponent({
</div>
</div>
</div>
<overflow-menu class="ui secondary pointing tabular borderless menu repos-filter">
<overflow-menu class="ui secondary pointing tabular borderless menu repos-filter" :active="reposFilter">
<div class="overflow-menu-items tw-justify-center">
<a class="item" tabindex="0" :class="{active: reposFilter === 'all'}" @click="changeReposFilter('all')">
{{ textAll }}
Expand Down
14 changes: 13 additions & 1 deletion web_src/js/webcomponents/overflow-menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import {throttle} from 'throttle-debounce';
import {createTippy} from '../modules/tippy.ts';
import {isDocumentFragmentOrElementNode} from '../utils/dom.ts';
import {isDocumentFragmentOrElementNode, toggleClass} from '../utils/dom.ts';
import octiconKebabHorizontal from '../../../public/assets/img/svg/octicon-kebab-horizontal.svg';

window.customElements.define('overflow-menu', class extends HTMLElement {
static observedAttributes = ['active'];

tippyContent: HTMLDivElement;
tippyItems: Array<HTMLElement>;
button: HTMLButtonElement;
Expand Down Expand Up @@ -151,6 +153,10 @@ window.customElements.define('overflow-menu', class extends HTMLElement {
}, 0);
},
});

this.tippyContent.querySelector('.item').addEventListener('click', () => {
this.button._tippy.hide();
});
});

init() {
Expand Down Expand Up @@ -218,6 +224,12 @@ window.customElements.define('overflow-menu', class extends HTMLElement {
}
}

attributeChangedCallback() {
if (!this.button || !this.tippyContent) return;
const containActiveInTippy = this.tippyContent.querySelector('.item.active');
toggleClass(this.button, 'active', Boolean(containActiveInTippy));
}

disconnectedCallback() {
this.mutationObserver?.disconnect();
this.resizeObserver?.disconnect();
Expand Down