Skip to content

Optimize Overflow Menu #34183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 13, 2025
Merged

Optimize Overflow Menu #34183

merged 9 commits into from
Apr 13, 2025

Conversation

kerwin612
Copy link
Member

Optimized the overflow-menu:

  1. Close the tippy when a menu item inside the tippy is clicked.
  2. When a menu item inside the tippy is selected, move the active state of the menu to the tippy's button.

bofore:
before

after:
after

@kerwin612
Optimized the overflow-menu:
f3fa4dd 
1. Close the tippy when a menu item inside the tippy is clicked.
2. When a menu item inside the tippy is selected, move the active state of the menu to the tippy's button.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 12, 2025
wxiaoguang
wxiaoguang approved these changes Apr 12, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, it looks good.

ps: IIRC there is a "addDelegatedEventListener", I will try to figure out whether we could use it to simply the code

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 12, 2025
@wxiaoguang
Copy link
Contributor

Actually, there was a bug: it shouldn't overflow in English:

image

@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Apr 12, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 12, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 13, 2025 01:59
@wxiaoguang wxiaoguang merged commit f4196a8 into go-gitea:main Apr 13, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the feat/optimize-overflow-menu branch April 13, 2025 01:59
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 14, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
91fa05b 
* giteaofficial/main: (27 commits)
  fix github migration error when using multiple tokens (go-gitea#34144)
  Add package version api endpoints (go-gitea#34173)
  Fix incorrect file links (go-gitea#34189)
  Add cache for common package queries (go-gitea#22491)
  Allow admins and org owners to change org member public status (go-gitea#28294)
  Fix span svg layout (go-gitea#34185)
  fix webhook url (go-gitea#34186)
  Optimize overflow-menu (go-gitea#34183)
  Move and rename UpdateRepository (go-gitea#34136)
  Update milestones.tmpl (go-gitea#34184)
  [skip ci] Updated translations via Crowdin
  Refactor Git Attribute & performance optimization (go-gitea#34154)
  [skip ci] Updated translations via Crowdin
  fix(go-gitea#33711): cross-publish docker images to ghcr.io (go-gitea#34148)
  refactor organization menu (go-gitea#33928)
  feat: Add sorting by exclusive labels (issue priority) (go-gitea#33206)
  Fix vertical centering of file tree icons and use entryIcon for submodules/symlinks (go-gitea#34137)
  bugfix check for alternate ssh host certificate location (go-gitea#34146)
  Cache GPG keys, emails and users when list commits (go-gitea#34086)
  Set MERMAID_MAX_SOURCE_CHARACTERS to 50000 (go-gitea#34152)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kerwin612 @wxiaoguang @lunny @GiteaBot