Skip to content

Conversation

iamsumit
Copy link
Contributor

@iamsumit iamsumit commented Mar 7, 2022

Related issue: #47

This PR fixes the parse error for installation repositories event for date fields by using time.Time instead of int64 type.

@deankarn
Copy link
Collaborator

deankarn commented Mar 8, 2022

@iamsumit would you be able to update the tests to use the new GitHub output? the tests seem to be failing.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.208% when pulling b793bbf on iamsumit:issue-47 into 9c954e2 on go-playground:master.

@iamsumit
Copy link
Contributor Author

iamsumit commented Mar 8, 2022

@iamsumit would you be able to update the tests to use the new GitHub output? the tests seem to be failing.

I fixed the tests. However, the integration_installation and integration_installation_repo events were failing due to the same issue. There is no such events listed on the github docs.

@alehechka
Copy link

Running into this same issue. I was able to replace the dependency with your fork, but wondering what the approval process is to get this merged in?

Copy link
Collaborator

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deankarn deankarn merged commit edaedd4 into go-playground:master Apr 30, 2022
Copy link

@mmfiv mmfiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants