Skip to content

Changed date field from int64 to time.Time to fix the parsing error. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2022
Merged

Changed date field from int64 to time.Time to fix the parsing error. #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f22656b
Changed date field from int64 to time.Time to fix the parsing error.
iamsumit Mar 7, 2022
c4e51bc
Updated test with new changes.
iamsumit Mar 8, 2022
b793bbf
Fixed test for integration installation events.
iamsumit Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions github/github_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ func TestWebhooks(t *testing.T) {
filename: "../testdata/github/installation.json",
headers: http.Header{
"X-Github-Event": []string{"installation"},
"X-Hub-Signature": []string{"sha1=2058cf6cc28570710afbc638e669f5c67305a2db"},
"X-Hub-Signature": []string{"sha1=2bcb4ad96133ce2dd6d140fad7a80a2b14407f7f"},
},
},
{
Expand All @@ -250,7 +250,7 @@ func TestWebhooks(t *testing.T) {
filename: "../testdata/github/installation-repositories.json",
headers: http.Header{
"X-Github-Event": []string{"installation_repositories"},
"X-Hub-Signature": []string{"sha1=c587fbd9dd169db8ae592b3bcc80b08e2e6f4f45"},
"X-Hub-Signature": []string{"sha1=997680ef1e6f4a6b6595f5fa70b82989f505137f"},
},
},
{
Expand All @@ -260,7 +260,7 @@ func TestWebhooks(t *testing.T) {
filename: "../testdata/github/integration-installation.json",
headers: http.Header{
"X-Github-Event": []string{"integration_installation"},
"X-Hub-Signature": []string{"sha1=bb2769f05f1a11af3a1edf8f9fac11bae7402a1e"},
"X-Hub-Signature": []string{"sha1=1172601d35bdebac5f3aa7618c9e58eafb404c6f"},
},
},
{
Expand All @@ -270,7 +270,7 @@ func TestWebhooks(t *testing.T) {
filename: "../testdata/github/integration-installation-repositories.json",
headers: http.Header{
"X-Github-Event": []string{"integration_installation_repositories"},
"X-Hub-Signature": []string{"sha1=2f00a982574188342c2894eb9d1b1e93434687fb"},
"X-Hub-Signature": []string{"sha1=7c38ba703a3c89d00823920a47cd8863df8121d2"},
},
},
{
Expand Down
16 changes: 8 additions & 8 deletions github/payload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,10 +1587,10 @@ type InstallationPayload struct {
PullRequests string `json:"pull_requests"`
RepositoryProjects string `json:"repository_projects"`
} `json:"permissions"`
Events []string `json:"events"`
CreatedAt int64 `json:"created_at"`
UpdatedAt int64 `json:"updated_at"`
SingleFileName *string `json:"single_file_name"`
Events []string `json:"events"`
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"`
SingleFileName *string `json:"single_file_name"`
} `json:"installation"`
Repositories []struct {
ID int64 `json:"id"`
Expand Down Expand Up @@ -1665,10 +1665,10 @@ type InstallationRepositoriesPayload struct {
Deployments string `json:"deployments"`
Contents string `json:"contents"`
} `json:"permissions"`
Events []string `json:"events"`
CreatedAt int64 `json:"created_at"`
UpdatedAt int64 `json:"updated_at"`
SingleFileName *string `json:"single_file_name"`
Events []string `json:"events"`
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"`
SingleFileName *string `json:"single_file_name"`
} `json:"installation"`
RepositoriesAdded []struct {
ID int64 `json:"id"`
Expand Down
4 changes: 2 additions & 2 deletions testdata/github/installation-repositories.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
"push",
"pull_request"
],
"created_at": 1525109898,
"updated_at": 1525109899,
"created_at": "2022-03-02T18:02:51.000Z",
"updated_at": "2022-03-02T18:02:51.000Z",
"single_file_name": "config.yml"
},
"repository_selection": "selected",
Expand Down
4 changes: 2 additions & 2 deletions testdata/github/installation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
"push",
"pull_request"
],
"created_at": 1525109898,
"updated_at": 1525109899,
"created_at": "2022-03-02T18:02:51.000Z",
"updated_at": "2022-03-02T18:02:51.000Z",
"single_file_name": "config.yml"
},
"repositories": [
Expand Down
4 changes: 2 additions & 2 deletions testdata/github/integration-installation-repositories.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
"push",
"pull_request"
],
"created_at": 1525109898,
"updated_at": 1525109899,
"created_at": "2022-03-02T18:02:51.000Z",
"updated_at": "2022-03-02T18:02:51.000Z",
"single_file_name": "config.yml"
},
"repository_selection": "selected",
Expand Down
4 changes: 2 additions & 2 deletions testdata/github/integration-installation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"events": [
"pull_request"
],
"created_at": 1516025475,
"updated_at": 1516025475,
"created_at": "2022-03-02T18:02:51.000Z",
"updated_at": "2022-03-02T18:02:51.000Z",
"single_file_name": null
},
"repositories": [
Expand Down