Vectors: Default, missing Vector2 constants, documentation

[Bromeon]

Completes a part of the recent Vector2/Vector3 refactoring:

• impl Default (zero vector) for both
• associated constants for Vector2
• documentation of constants

Let me know if there's other obvious things that could fit.

[ghost]

Looks good to me! One tiny point about the docs of INF.

[ghost]

Not sure if the distinction is important to make, but I've heard positive infinity be called +Infinity for clarity elsewhere.

[Bromeon]

I can clarify that.

Maybe a general question, what's the use case of this INF constant? Some "default" intervals like [-Vector2.INF, Vector2.INF] which are interpreted component-wise?

And secondly, we do want to map every single constant that exists in Godot for completeness, independently of how useful it is, right? (also because it may not be easy to measure utility...)

[ghost]

Use case of INF... we do want to map every single constant that exists in Godot for completeness, independently of how useful it is, right? (also because it may not be easy to measure utility...)

I don't know, and yes I think you nailed the problem here. I'd err on the side of accepting constants of dubious usefulness because of this. There isn't a downside imo.

[ghost]

Looks good to me. Thanks!

bors r+

[Bromeon]

Documented "+infinity", no changes otherwise.

Regarding the new Vector API, there's one other issue I'm currently aware of -- a compiler warning:

warning: associated function is never used: `glam`
  --> gdnative-core\src\core_types\quat.rs:27:8
   |
27 |     fn glam(self) -> glam::Quat {
   |        ^^^^
   |
   = note: `#[warn(dead_code)]` on by default

We could suppress it now, or work on the Quat API, or leave it active as a reminder that we should complete the API at some point 🙂

[ghost]

We could suppress it now, or work on the Quat API, or leave it active as a reminder that we should complete the API at some point 🙂

Ideally we want 2, of course, but you don't have to work on it if you don't want to. 3 is a good idea, even though it might interfere with workflows where all warnings are denied (not the best idea imo, since that is simply opting out of Rust's stability). I think it can be left as is for now.

[bors]

Build succeeded:

• ci