Update to Godot 3.3

[jdfreder]

Hi, thanks for the great bindings!

Now that Godot 3.3 is the stable branch I thought that it made sense to update my local copy. Just upstreaming it incase it saves you time.

Tested:
cargo test
I also verified that the hello-world example runs in the Godot IDE

[ghost]

Thanks for the PR! Could you keep the scope to updating api.json and revert the changes to the version numbers everywhere? We only bump them when we actually make releases. Having them randomly bumped in individual PRs would be messy to keep track of, and troublesome should we ever want to revert one of them.

You'll also want to update the API documentation XMLs from Godot's repo, in addition to api.json, so the generated docs would be up-to-date. Keep in mind that their master branch is for 4.0. You'll want to checkout the release commit and copy from there.

[Bromeon]

If I understood it right, we would still be compatible with Godot 3.2., as 3.3 is technically a 3.2. release, with a large enough scope to justify minor version bump (but no breaking changes).

If that's the case, maybe we should mention this in the ReadMe.

[ghost]

If I understood it right, we would still be compatible with Godot 3.2., as 3.3 is technically a 3.2. release, with a large enough scope to justify minor version bump (but no breaking changes).

If that's the case, maybe we should mention this in the ReadMe.

Yes, so it isn't really necessary to change the ReadMe: our minimum supported stable branch (with API.json replacement) is still 3.2. Changing the default API version does not change that. In any case, the crate version on master shouldn't really be bumped in this. We might want to consider releasing a further patch release in 0.9.x, though, since 0.10 might still take a while.

[jdfreder]

Thanks for the PR! Could you keep the scope to updating api.json and revert the changes to the version numbers everywhere? We only bump them when we actually make releases. Having them randomly bumped in individual PRs would be messy to keep track of, and troublesome should we ever want to revert one of them.

You'll also want to update the API documentation XMLs from Godot's repo, in addition to api.json, so the generated docs would be up-to-date. Keep in mind that their master branch is for 4.0. You'll want to checkout the release commit and copy from there.

Done

[ghost]

Looks good to me. Thanks!

bors r+

[bors]

Build succeeded:

• ci