[macOS export] Set correct external file attributes, and creation time. #39977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
added
bug
platform:macos
topic:editor
cherrypick:3.x
akien-mga
approved these changes
Jun 30, 2020
|
Thanks! |
follower
reviewed
Jun 30, 2020
| // 0000755: permissions rwxr-xr-x | ||
| // 0000644: permissions rw-r--r-- | ||
| zipfi.external_fa = (is_executable ? 0100755 : 0100644) << 16L; | ||
| uint32_t _mode = (is_executable ? 0100755 : 0100644); |
There was a problem hiding this comment.
A comment along the lines of "Bit-wise operators on signed integers are undefined and probably made the result compiler specific." from #39931 (comment) seems like it would be valuable here as an explanation for why this is implemented in this manner.
|
Re: "(lost +x flag, and broken files when extracting with macOS Archive Utility)" AFAICT the latest issue wasn't specific to Archive Utility extraction? Also, given that currently 3.2.2 export to Mac |
|
Cherry-picked for 3.2.3. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes file creation date (TM month range is 0…11,
OS::get_date()month range is 1…12).Fixes file attributes (lost +x flag, and broken files when extracting with macOS
Archive Utility), do it like info-zip do:unix/unix.c#L382
Fixes: #39931