x/sys: golang.org/x/crypto/ssh/terminal fail for windows

[le0pard]

What version of Go are you using (go version)?

$ go version
go version go1.13 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GO111MODULE="auto"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/travis/.cache/go-build"
GOENV="/home/travis/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/travis/gopath"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/travis/.gimme/versions/go1.13.linux.amd64"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/travis/.gimme/versions/go1.13.linux.amd64/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build020438651=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Building https://github.com/le0pard/certonid

Result: https://travis-ci.com/le0pard/certonid/jobs/238002946

--> windows/amd64 error: exit status 2
Stderr: # golang.org/x/crypto/ssh/terminal
../../../golang.org/x/crypto/ssh/terminal/util_windows.go:97:7: assignment mismatch: 2 variables but "golang.org/x/sys/windows".GetCurrentProcess returns 1 values

What did you expect to see?

No errors for windows build.

What did you see instead?

Errors. Reason looks like in this commit:

golang/sys@2dccfee

It change return values from 2 to 1. This break this code: https://github.com/golang/crypto/blob/master/ssh/terminal/util_windows.go#L97

[gopherbot]

Change https://golang.org/cl/196897 mentions this issue: ssh/terminal: account for win32 api changes

[zx2c4]

Trivial fix on its way in that CL.

[toothrot]

Looks like a deliberate breaking API change in x/sys/windows

/cc @FiloSottile for x/crypto
/cc @alexbrainman @bradfitz Do we know other places this could be broken in our x/ repos from golang/sys@2dccfee?